From: Harald Freudenberger <freude@linux.ibm.com>
To: dengler@linux.ibm.com, fcallies@linux.ibm.com, ifranzki@linux.ibm.com
Cc: freude@linux.ibm.com, linux-s390@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>
Subject: [PATCH v5 0/1] Fix and improve zcrypt reply message checks
Date: Fri, 2 Oct 2026 12:52:35 +0200 [thread overview]
Message-ID: <20261002105236.52049-1-freude@linux.ibm.com> (raw)
Fix and improve zcrypt reply messages checks of type 6 - CCA and EP11
- and type 50 - ICA.
Changelog:
v1: Initial version
v2: Sashiko complained about not checking offset1/count1 at all if
count2 for an CCA type6 reply is given. And a check like this was
in place before the rework. So now offset1/count1 is always
checked and only if count2 is non zero offset2/count2 is
additionally checked.
v3: Again Sashiko had some complains which let to a broader review of
the reply processing functions. Especially the zcrypt_type50.c
functions convert_type80() and convert_response() got slight but
significant improvements - and also a mysterious BUG_ON has been
removed.
v4: Again Sashiko had a complain about my restrictions are too
tight. So now in convert_response_xcrb() the exact length
verification is:
case TYPE86_RSP_CODE:
...
if (reply->len < sizeof(struct type86_fmt2_msg) +
offsetof(struct CPRBX, cprb_ver_id) +
sizeof(msg->cprbx.cprb_ver_id))
return -EINVAL;
...
thus postponing the final length check to the convert function
(which does the job hopefully correct).
v5: Sashiko noticed that for two functions (convert_response_ica and
convert_response_ep11_xcrb) the length check comes before the
processing of short error replies - fixed.
Harald Freudenberger (1):
s390/zcrypt: Fix and improve zcrypt reply message verification checks
drivers/s390/crypto/zcrypt_msgtype50.c | 95 ++++++++----
drivers/s390/crypto/zcrypt_msgtype6.c | 202 ++++++++++++++++++-------
2 files changed, 218 insertions(+), 79 deletions(-)
--
2.43.0
next reply other threads:[~2026-10-02 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 10:52 Harald Freudenberger [this message]
2026-10-02 10:52 ` [PATCH v5 1/1] s390/zcrypt: Fix and improve zcrypt reply message verification checks Harald Freudenberger
2026-10-02 11:09 ` sashiko-bot
2026-10-02 13:29 ` Holger Dengler
2026-10-05 8:36 ` Heiko Carstens
2026-10-02 14:53 ` [PATCH v5 0/1] Fix and improve zcrypt reply message checks Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261002105236.52049-1-freude@linux.ibm.com \
--to=freude@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=dengler@linux.ibm.com \
--cc=fcallies@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=ifranzki@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox