Linux s390 Architecture development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Heiko Carstens" <hca@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH 1/2] s390/entry: Last breaking event vs invalid kernel stack
Date: Sat, 03 Oct 2026 01:33:07 +0000	[thread overview]
Message-ID: <20261003013307.B61681F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261002152055.3305184-2-hca@linux.ibm.com>

> In case an invalid kernel stack is detected the last breaking event
> address is copied to the orig_gpr2 member of the generated pt_regs
> structure. Correct location would be last_break. Fix this.
> 
> This adds help information to the printed messages:
> 
> Before:
> Kernel stack pointer invalid
> ...
> Last Breaking-Event-Address:
>  [<0000000000000000>] 0x0
> 
> After:
> Kernel stack pointer invalid
> ...
> Last Breaking-Event-Address:
>  [<000001b802c1ae1c>] proc_reg_write+0x5c/0xd0
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261002152055.3305184-1-hca@linux.ibm.com?part=1


  reply	other threads:[~2026-10-03  1:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-02 15:20 [PATCH 0/2] s390: Improve handling for stack register corruption Heiko Carstens
2026-10-02 15:20 ` [PATCH 1/2] s390/entry: Last breaking event vs invalid kernel stack Heiko Carstens
2026-10-03  1:33   ` sashiko-bot [this message]
2026-10-02 15:20 ` [PATCH 2/2] s390/entry: Save lowcore on " Heiko Carstens
2026-10-03  1:33   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261003013307.B61681F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox