From: sashiko-bot@kernel.org
To: "Harald Freudenberger" <freude@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH v1 1/2] s390/cpacf: Rework cpacf_kma() to return condition code
Date: Mon, 05 Oct 2026 14:23:14 +0000 [thread overview]
Message-ID: <20261005142314.D39341F00893@smtp.kernel.org> (raw)
In-Reply-To: <20261005141417.65822-2-freude@linux.ibm.com>
> The KMA instruction can signal a verification-pattern mismatch (CC 1)
> when a protected key is used, or incomplete processing (CC 2) when a
> sub-block-size chunk is submitted without the appropriate LAAD/LPC
> flag. Both conditions shall be visible to the caller similar like the
> other CPACF instructions.
>
> So rework the cpacf_kma() inline function to return the condition code
> instead of void. However, CC 3 (partial completion) continues to be
> handled internally. Also improve the function to use the CC macros for
> better readability. Additionally add an kmsan_unpoison_memory()
> statement to reflect the updated memory by hardware.
>
> Signed-off-by: Harald Freudenberger <freude@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261005141417.65822-1-freude@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-10-05 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 14:14 [PATCH v1 0/2] Rework cpacf_kma() function Harald Freudenberger
2026-10-05 14:14 ` [PATCH v1 1/2] s390/cpacf: Rework cpacf_kma() to return condition code Harald Freudenberger
2026-10-05 14:23 ` sashiko-bot [this message]
2026-10-06 7:48 ` Holger Dengler
2026-10-06 8:30 ` Heiko Carstens
2026-10-06 13:29 ` Harald Freudenberger
2026-10-06 13:39 ` Heiko Carstens
2026-10-06 14:16 ` Harald Freudenberger
2026-10-06 15:13 ` Heiko Carstens
2026-10-05 14:14 ` [PATCH v1 2/2] s390/crypto: Handle cpacf_kma() return code Harald Freudenberger
2026-10-05 14:20 ` sashiko-bot
2026-10-06 7:52 ` Holger Dengler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005142314.D39341F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox