Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 3/4] s390/percpu: Drop unused output register from arch_this_cpu_to_op()
Date: Mon, 12 Oct 2026 13:42:48 +0200	[thread overview]
Message-ID: <20261012114249.2898572-4-hca@linux.ibm.com> (raw)
In-Reply-To: <20261012114249.2898572-1-hca@linux.ibm.com>

The lan/lang/lao/laog instructions return the old memory content, but
arch_this_cpu_to_op() does not need it. Instead of allocating a dedicated
output register old__ just to discard the returned value, change the
val__ constraint from "d" to "+&d" so it is used as input/output
register.

This reduces register pressure.

Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---
 arch/s390/include/asm/percpu.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/s390/include/asm/percpu.h b/arch/s390/include/asm/percpu.h
index fd0a3a9951ce..7d87e0a262c3 100644
--- a/arch/s390/include/asm/percpu.h
+++ b/arch/s390/include/asm/percpu.h
@@ -257,18 +257,18 @@ do {									\
 	typedef typeof(pcp) pcp_op_T__; 				\
 	union register_pair rp__;					\
 	pcp_op_T__ val__ = (val);					\
-	pcp_op_T__ old__, *ptr__;					\
+	pcp_op_T__ *ptr__;						\
 									\
 	ptr__ = PERCPU_PTR(&(pcp));					\
 	asm_inline volatile(						\
 		__PCPU_BEGIN("%[lcreg]","%[lcoff]","%[ptr__]",		\
 			     "%[pair__]","%N[pair__]")			\
-		op "    %[old__],%[val__],0(%N[pair__])\n"		\
+		op "    %[val__],%[val__],0(%N[pair__])\n"		\
 		__PCPU_END("%[lcreg]")					\
-		: [old__] "=&d" (old__), [pair__] "=&a" (rp__.pair),	\
+		: [val__] "+&d" (val__), [pair__] "=&a" (rp__.pair),	\
 		  "+m" (*ptr__),					\
 		  "=m" (((struct lowcore *)0)->percpu_register)		\
-		: [val__] "d" (val__), [ptr__] "a" (ptr__),		\
+		: [ptr__] "a" (ptr__),					\
 		  [lcreg] "i" (LC_PERCPU_REGISTER),			\
 		  [lcoff] "i" (LC_PERCPU_OFFSET),			\
 		  "m" (((struct lowcore *)0)->percpu_offset)		\
-- 
2.53.0


  parent reply	other threads:[~2026-10-12 11:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 11:42 [PATCH 0/4] s390/percpu: More small improvements Heiko Carstens
2026-10-12 11:42 ` [PATCH 1/4] s390/percpu: Use asm_inline for arch_this_cpu_add() Heiko Carstens
2026-10-12 11:46   ` sashiko-bot
2026-10-12 12:41   ` Alexander Gordeev
2026-10-12 11:42 ` [PATCH 2/4] s390/percpu: Drop unused output register from arch_this_cpu_add() Heiko Carstens
2026-10-12 11:51   ` sashiko-bot
2026-10-12 13:24   ` Alexander Gordeev
2026-10-12 14:16     ` Heiko Carstens
2026-10-12 14:34   ` Alexander Gordeev
2026-10-12 11:42 ` Heiko Carstens [this message]
2026-10-12 11:54   ` [PATCH 3/4] s390/percpu: Drop unused output register from arch_this_cpu_to_op() sashiko-bot
2026-10-12 12:18     ` Heiko Carstens
2026-10-12 14:35   ` Alexander Gordeev
2026-10-12 11:42 ` [PATCH 4/4] s390/percpu: Implement this_cpu_try_cmpxchg() Heiko Carstens
2026-10-12 11:51   ` sashiko-bot
2026-10-12 15:11   ` Alexander Gordeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261012114249.2898572-4-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox