Re: [PATCH v4] s390/diag204: Introduce diag204 rework

[Heiko Carstens <hca@linux.ibm.com>]

On Tue, Oct 27, 2026 at 12:53:22PM +0100, Mete Durlu wrote:
> > > + * diag204_init() has to find out, which type of diagnose 204 implementation
> > > + * we have on the machine. Currently there are three possible scanarios:
> > > + *   - subcode 4   + simple data format (only one page)
> > > + *   - subcode 4-6 + extended data format
> > > + *   - subcode 4-7 + extended data format
> > > + *
> > > + * Subcode 5 is used to retrieve the size of the data, provided by subcodes
> > > + * 6 and 7. Subcode 7 basically has the same function as subcode 6. In addition
> > > + * to subcode 6 it provides also information about secondary cpus.
> > > + * In order to get as much information as possible, we first try
> > > + * subcode 7, then 6 and if both fail, we use subcode 4.
> > > + */
> > 
> > This looks like it was copied from the old code: please fix the documentation
> > convert to use imperative mood when you move it.
> 
> Will do! Should it retain the details about which subcodes and
> data formats can exist together?

Sure, I don't see a reason to remove information.

FWIW, it would be helpful if you would reply-to-all, and not only the list :)