Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	Sven Schnelle <svens@linux.ibm.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v2 12/14] s390/sclp_ftp: Replace get_zeroed_page() with kzalloc()
Date: Tue, 17 Nov 2026 16:34:06 +0100	[thread overview]
Message-ID: <20261117153406.32016C4e-hca@linux.ibm.com> (raw)
In-Reply-To: <20261117-s390-sclp-ready-v2-12-e518c99622c6@kernel.org>

On Tue, Nov 17, 2026 at 03:07:04PM +0200, Mike Rapoport (Microsoft) wrote:
> sclp_ftp_et7() allocates the SCCB used for an HMC file transfer request
> and sclp_ftp_startup() allocates the buffer for the SYSIB 2.2.2 stored
> by stsi() in the debug code.
> 
> These buffers can be allocated with kmalloc() as there's nothing special
> about them to go directly to the page allocator.
> 
> kmalloc() provides a better API that does not require ugly casts and
> kfree() does not need to know the size of the freed object.
> 
> Performance difference between kmalloc() and __get_free_pages() is not
> measurable as both allocators take an object/page from a per-CPU list for
> fast path allocations.
> 
> For the slow path the performance is anyway determined by the amount of
> reclaim involved rather than by what allocator is used.
> 
> While on it, make the SYSIB 2.2.2 buffer a struct sysinfo_2_2_2 pointer
> to get rid of the casts.
> 
> Replace use of get_zeroed_page() with kzalloc() and free_page() with
> kfree().
> 
> Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@redhat.com
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
>  drivers/s390/char/sclp_ftp.c | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>

Thanks for the series. Will be picked up and routed via s390.

  parent reply	other threads:[~2026-11-17 15:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 13:06 [PATCH v2 00/14] s390/sclp: replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-17 13:06 ` [PATCH v2 01/14] s390/sclp_vt220: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 02/14] s390/sclp_config: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 03/14] s390/sclp_pci: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 04/14] s390/sclp_ctl: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 05/14] s390/sclp_con: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 06/14] s390/sclp_tty: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:06 ` [PATCH v2 07/14] s390/sclp: Replace __get_free_page() with kmalloc() Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:07 ` [PATCH v2 08/14] s390/sclp_sdias: " Mike Rapoport (Microsoft)
2026-11-17 14:12   ` sashiko-bot
2026-11-17 13:07 ` [PATCH v2 09/14] s390/sclp_sd: " Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot
2026-11-17 13:07 ` [PATCH v2 10/14] s390/sclp_cmd: Replace page allocator calls with kzalloc() Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot
2026-11-17 15:33   ` Heiko Carstens
2026-11-17 13:07 ` [PATCH v2 11/14] s390/sclp_cpi: Replace get_zeroed_page() " Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot
2026-11-17 13:07 ` [PATCH v2 12/14] s390/sclp_ftp: " Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot
2026-11-17 15:34   ` Heiko Carstens [this message]
2026-11-17 13:07 ` [PATCH v2 13/14] s390/sclp_mem: Replace page allocator calls with k[mz]alloc() Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot
2026-11-17 13:07 ` [PATCH v2 14/14] s390/sclp_ap: Replace get_zeroed_page() with kzalloc() Mike Rapoport (Microsoft)
2026-11-17 14:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261117153406.32016C4e-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=svens@linux.ibm.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox