From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
Andrew Jones <andrew.jones@linux.dev>,
Colton Lewis <coltonlewis@google.com>,
Nikos Nikoleris <nikos.nikoleris@arm.com>,
Sean Christopherson <seanjc@google.com>,
Shaoqin Huang <shahuang@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 4/9] s390x: topology: Don't use non unique message
Date: Fri, 13 Oct 2023 11:18:13 +0200 [thread overview]
Message-ID: <2172cf228f38150844ddf1af9e4f453238d85a29.camel@linux.ibm.com> (raw)
In-Reply-To: <169718501727.15841.5127785267238990595@t14-nrb>
On Fri, 2023-10-13 at 10:16 +0200, Nico Boehr wrote:
> Quoting Nina Schoetterl-Glausch (2023-10-11 10:56:27)
> > When we test something, i.e. do a report() we want unique messages,
> > otherwise, from the test output, it will appear as if the same test was
> > run multiple times, possible with different PASS/FAIL values.
> >
> > Convert some reports that don't actually test anything topology specific
> > into asserts.
> > Refine the report message for others.
> >
> > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
>
> There is still the "TLE: reserved bits 0000000000000000" message which may
> be duplicate, but I think you fix that in a later patch.
>
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
Yes, this isn't comprehensive, the rewrite takes care of the rest.
next prev parent reply other threads:[~2023-10-13 9:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 8:56 [kvm-unit-tests PATCH 0/9] s390x: topology: Fixes and extension Nina Schoetterl-Glausch
2023-10-11 8:56 ` [kvm-unit-tests PATCH 1/9] s390x: topology: Fix report message Nina Schoetterl-Glausch
2023-10-11 10:56 ` Janosch Frank
2023-10-11 11:10 ` Nina Schoetterl-Glausch
2023-10-11 11:30 ` Janosch Frank
2023-10-11 11:41 ` Nina Schoetterl-Glausch
2023-10-11 13:36 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 2/9] s390x: topology: Use parameter in stsi_get_sysib Nina Schoetterl-Glausch
2023-10-11 11:05 ` Janosch Frank
2023-10-12 14:44 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 3/9] s390x: topology: Fix parsing loop Nina Schoetterl-Glausch
2023-10-11 11:07 ` Janosch Frank
2023-10-11 11:16 ` Nina Schoetterl-Glausch
2023-10-12 14:46 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 4/9] s390x: topology: Don't use non unique message Nina Schoetterl-Glausch
2023-10-11 11:11 ` Janosch Frank
2023-10-13 8:16 ` Nico Boehr
2023-10-13 9:18 ` Nina Schoetterl-Glausch [this message]
2023-10-11 8:56 ` [kvm-unit-tests PATCH 5/9] s390x: topology: Refine stsi header test Nina Schoetterl-Glausch
2023-10-11 11:16 ` Janosch Frank
2023-10-11 11:19 ` Nina Schoetterl-Glausch
2023-10-11 11:22 ` Janosch Frank
2023-10-17 12:31 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 6/9] s390x: topology: Rename topology_core to topology_cpu Nina Schoetterl-Glausch
2023-10-11 11:31 ` Janosch Frank
2023-10-17 12:32 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 7/9] s390x: topology: Rewrite topology list test Nina Schoetterl-Glausch
2023-10-17 13:29 ` Nico Boehr
2023-10-11 8:56 ` [kvm-unit-tests PATCH 9/9] s390x: topology: Add complex topology test Nina Schoetterl-Glausch
2023-10-19 10:58 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2172cf228f38150844ddf1af9e4f453238d85a29.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=andrew.jones@linux.dev \
--cc=coltonlewis@google.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nikos.nikoleris@arm.com \
--cc=nrb@linux.ibm.com \
--cc=seanjc@google.com \
--cc=shahuang@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox