From: Karsten Graul <kgraul@linux.ibm.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, hca@linux.ibm.com,
raspl@linux.ibm.com
Subject: Re: [PATCH net-next v3 15/15] net/smc: Add support for obtaining system information
Date: Mon, 9 Nov 2020 11:01:57 +0100 [thread overview]
Message-ID: <22bd2535-4057-12a2-ae6b-fefd33129e98@linux.ibm.com> (raw)
In-Reply-To: <20201107095540.0f45b572@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 07/11/2020 18:55, Jakub Kicinski wrote:
> On Sat, 7 Nov 2020 13:59:58 +0100 Karsten Graul wrote:
>> From: Guvenc Gulce <guvenc@linux.ibm.com>
>>
>> Add new netlink command to obtain system information
>> of the smc module.
>>
>> Signed-off-by: Guvenc Gulce <guvenc@linux.ibm.com>
>> Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
>
> Checkpatch says:
>
> CHECK: Please don't use multiple blank lines
> #62: FILE: include/uapi/linux/smc_diag.h:140:
>
> +
>
> WARNING: line length of 84 exceeds 80 columns
> #172: FILE: net/smc/smc_diag.c:687:
> + smcd_dev = list_first_entry_or_null(&dev_list->list, struct smcd_dev, list);
>
The checkpatch.pl script in net-next does not bring up this length warning.
We will address it in a v4.
--
Karsten
(I'm a dude)
prev parent reply other threads:[~2020-11-09 10:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 12:59 [PATCH net-next v3 00/15] net/smc: extend diagnostic netlink interface Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 01/15] net/smc: use helper smc_conn_abort() in listen processing Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 02/15] net/smc: Use active link of the connection Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 03/15] net/smc: Add connection counters for links Karsten Graul
2020-11-07 17:57 ` Jakub Kicinski
2020-11-07 12:59 ` [PATCH net-next v3 04/15] net/smc: Add link counters for IB device ports Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 05/15] net/smc: Add diagnostic information to smc ib-device Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 06/15] net/smc: Add diagnostic information to link structure Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 07/15] net/smc: Refactor the netlink reply processing routine Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 08/15] net/smc: Add ability to work with extended SMC netlink API Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 09/15] net/smc: Introduce SMCR get linkgroup command Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 10/15] net/smc: Introduce SMCR get link command Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 11/15] net/smc: Add SMC-D Linkgroup diagnostic support Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 12/15] net/smc: Add support for obtaining SMCD device list Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 13/15] net/smc: Add support for obtaining SMCR " Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 14/15] net/smc: Refactor smc ism v2 capability handling Karsten Graul
2020-11-07 12:59 ` [PATCH net-next v3 15/15] net/smc: Add support for obtaining system information Karsten Graul
2020-11-07 17:55 ` Jakub Kicinski
2020-11-09 10:01 ` Karsten Graul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22bd2535-4057-12a2-ae6b-fefd33129e98@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox