public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Wen Gu <guwen@linux.alibaba.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: wintera@linux.ibm.com, wenjia@linux.ibm.com, hca@linux.ibm.com,
	gor@linux.ibm.com, agordeev@linux.ibm.com, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com, kgraul@linux.ibm.com,
	jaka@linux.ibm.com, borntraeger@linux.ibm.com,
	svens@linux.ibm.com, alibuda@linux.alibaba.com,
	tonylu@linux.alibaba.com, raspl@linux.ibm.com,
	schnelle@linux.ibm.com, linux-s390@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/7] net/smc: compatible with 128-bits extend GID of virtual ISM device
Date: Thu, 23 Nov 2023 21:16:39 +0800	[thread overview]
Message-ID: <24ea5034-78ef-c173-3739-fb05418f8d11@linux.alibaba.com> (raw)
In-Reply-To: <20231120111739.31baf90a@kernel.org>



On 2023/11/21 03:17, Jakub Kicinski wrote:
> On Sun, 19 Nov 2023 21:57:55 +0800 Wen Gu wrote:
>> According to virtual ISM support feature defined by SMCv2.1, GIDs of
>> virtual ISM device are UUIDs defined by RFC4122, which are 128-bits
>> long. So some adaptation work is required. And note that the GIDs of
>> existing platform firmware ISM devices still remain 64-bits long.
> 
> sparse (C=1 build) complains:
> 
> net/smc/smc_clc.c:944:73: warning: incorrect type in argument 1 (different base types)
> net/smc/smc_clc.c:944:73:    expected unsigned short [usertype] chid
> net/smc/smc_clc.c:944:73:    got restricted __be16 [usertype] chid

It will be fixed in the next version. Thank you very much!

Thanks,
Wen Gu

  reply	other threads:[~2023-11-23 13:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-19 13:57 [PATCH net-next 0/7] net/smc: implement SMCv2.1 virtual ISM device support Wen Gu
2023-11-19 13:57 ` [PATCH net-next 1/7] net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity Wen Gu
2023-11-19 13:57 ` [PATCH net-next 2/7] net/smc: support SMCv2.x supplemental features negotiation Wen Gu
2023-11-19 13:57 ` [PATCH net-next 3/7] net/smc: introduce virtual ISM device support feature Wen Gu
2023-11-19 13:57 ` [PATCH net-next 4/7] net/smc: define a reserved CHID range for virtual ISM devices Wen Gu
2023-11-19 13:57 ` [PATCH net-next 5/7] net/smc: compatible with 128-bits extend GID of virtual ISM device Wen Gu
2023-11-20 19:17   ` Jakub Kicinski
2023-11-23 13:16     ` Wen Gu [this message]
2023-11-22 19:07   ` Simon Horman
2023-11-23 13:39     ` Wen Gu
2023-11-19 13:57 ` [PATCH net-next 6/7] net/smc: disable SEID on non-s390 archs where virtual ISM may be used Wen Gu
2023-11-19 13:57 ` [PATCH net-next 7/7] net/smc: manage system EID in SMC stack instead of ISM driver Wen Gu
2023-11-24 13:11 ` [PATCH net-next 0/7] net/smc: implement SMCv2.1 virtual ISM device support Wenjia Zhang
2023-11-24 13:34   ` Wen Gu
2023-11-24 13:37     ` Wen Gu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24ea5034-78ef-c173-3739-fb05418f8d11@linux.alibaba.com \
    --to=guwen@linux.alibaba.com \
    --cc=agordeev@linux.ibm.com \
    --cc=alibuda@linux.alibaba.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=jaka@linux.ibm.com \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=raspl@linux.ibm.com \
    --cc=schnelle@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    --cc=tonylu@linux.alibaba.com \
    --cc=wenjia@linux.ibm.com \
    --cc=wintera@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox