From: Benjamin Block <bblock@linux.ibm.com>
To: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Julian Wiedmann <jwi@linux.ibm.com>,
Benjamin Block <bblock@linux.ibm.com>,
Steffen Maier <maier@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Fedor Loshakov <loshakov@linux.ibm.com>,
Sumangala Bannur Subraya <bsuma@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [PATCH 1/6] zfcp: remove unneeded INIT_LIST_HEAD() for FSF requests
Date: Wed, 14 Apr 2021 19:07:59 +0200 [thread overview]
Message-ID: <254dc0ae28dccc43ab0b1079ef2c8dcb5fe1d2e4.1618417667.git.bblock@linux.ibm.com> (raw)
In-Reply-To: <cover.1618417667.git.bblock@linux.ibm.com>
From: Julian Wiedmann <jwi@linux.ibm.com>
INIT_LIST_HEAD() is only needed for actual list heads, while req->list
is used as a list entry.
Note that when the error path in zfcp_fsf_req_send() removes the request
from the adapter's list of pending requests, it actually looks up the
request from the zfcp_reqlist - rather than just calling list_del().
So there's no risk of us calling list_del() on a request that hasn't
been added to any list yet.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
---
drivers/s390/scsi/zfcp_fsf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/scsi/zfcp_fsf.c b/drivers/s390/scsi/zfcp_fsf.c
index 485028324eae..2e4804ef2fb9 100644
--- a/drivers/s390/scsi/zfcp_fsf.c
+++ b/drivers/s390/scsi/zfcp_fsf.c
@@ -846,7 +846,6 @@ static struct zfcp_fsf_req *zfcp_fsf_req_create(struct zfcp_qdio *qdio,
if (adapter->req_no == 0)
adapter->req_no++;
- INIT_LIST_HEAD(&req->list);
timer_setup(&req->timer, NULL, 0);
init_completion(&req->completion);
--
2.30.2
next prev parent reply other threads:[~2021-04-14 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 17:07 [PATCH 0/6] zfcp: cleanups and qdio code refactor for 5.13/5.14 Benjamin Block
2021-04-14 17:07 ` Benjamin Block [this message]
2021-04-14 17:08 ` [PATCH 2/6] zfcp: fix indentation coding style issue Benjamin Block
2021-04-14 17:08 ` [PATCH 3/6] zfcp: fix sysfs roll-back on error in zfcp_adapter_enqueue() Benjamin Block
2021-04-14 17:08 ` [PATCH 4/6] zfcp: clean up sysfs code for SFP diagnostics Benjamin Block
2021-04-14 17:08 ` [PATCH 5/6] scsi: zfcp: move the position of put_device Benjamin Block
2021-04-14 17:08 ` [PATCH 6/6] scsi: zfcp: lift Request Queue tasklet & timer from qdio Benjamin Block
2021-04-16 2:20 ` [PATCH 0/6] zfcp: cleanups and qdio code refactor for 5.13/5.14 Martin K. Petersen
2021-04-18 16:04 ` Benjamin Block
2021-04-20 2:29 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254dc0ae28dccc43ab0b1079ef2c8dcb5fe1d2e4.1618417667.git.bblock@linux.ibm.com \
--to=bblock@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=bsuma@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=loshakov@linux.ibm.com \
--cc=maier@linux.ibm.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox