Re: [PATCH AUTOSEL 4.19 204/205] s390/qeth: limit csum offload erratum to L3 devices

[Julian Wiedmann <jwi@linux.ibm.com>]

On 08.11.19 20:35, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Fri, 8 Nov 2019 13:34:16 +0100
> 
>> On Fri, Nov 08, 2019 at 01:16:26PM +0100, Julian Wiedmann wrote:
>>> On 08.11.19 13:00, Sasha Levin wrote:
>>>> On Fri, Nov 08, 2019 at 12:50:24PM +0100, Julian Wiedmann wrote:
>>>>> On 08.11.19 12:37, Sasha Levin wrote:
>>>>>> From: Julian Wiedmann <jwi@linux.ibm.com>
>>>>>>
>>>>>> [ Upstream commit f231dc9dbd789b0f98a15941e3cebedb4ad72ad5 ]
>>>>>>
>>>>>> Combined L3+L4 csum offload is only required for some L3 HW. So for
>>>>>> L2 devices, don't offload the IP header csum calculation.
>>>>>>
>>>>>
>>>>> NACK, this has no relevance for stable.
>>>>
>>>> Sure, I'll drop it.
>>>>
>>>> Do you have an idea why the centos and ubuntu folks might have
>>>> backported this commit into their kernels?
>>>>
>>>
>>> No clue, I trust they have their own reasons.
>>>
>>
>> I cant see centos backporting anything unless they were asked to do so.
>> And this really looks like a "bugfix" to me, why isn't this relevant for
>> any older kernel versions?
> 
> Yeah seriously, this looks entirely legit.
> 

I can assure you this doesn't fix any actual bug, and there's zero user
impact from _not_ having this patch.