From: Janosch Frank <frankja@linux.ibm.com>
To: Christoph Schlameuss <schlameuss@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
imbrenda@linux.ibm.com, nrb@linux.ibm.com, npiggin@gmail.com,
nsg@linux.ibm.com, mhartmay@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 1/4] s390x: Split snippet makefile rules into new file
Date: Fri, 2 Aug 2024 11:34:04 +0200 [thread overview]
Message-ID: <2f3bfc34-dbb1-4f49-bed3-bf373a9ac736@linux.ibm.com> (raw)
In-Reply-To: <20240725162700.57f08e82.schlameuss@linux.ibm.com>
On 7/25/24 4:27 PM, Christoph Schlameuss wrote:
> On Thu, 18 Jul 2024 10:50:16 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
>
>> It's time to move the snippet related Makefile parts into a new file
>> to make s390x/Makefile less busy.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/Makefile | 34 ++++------------------------------
>> s390x/snippets/Makefile | 30 ++++++++++++++++++++++++++++++
>> 2 files changed, 34 insertions(+), 30 deletions(-)
>> create mode 100644 s390x/snippets/Makefile
>
> IMHO the commit message should start with "s390x/Makefile: Split snippet
> makefile rules into new file" for more consistency.
>
> With that fixed:
> Reviewed-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
Sure
I'll send a new version around anyway, since I've rebased the series on
Marc's make file patch.
next prev parent reply other threads:[~2024-08-02 9:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 10:50 [kvm-unit-tests PATCH 0/4] s390x: split off snippet and sie related code Janosch Frank
2024-07-18 10:50 ` [kvm-unit-tests PATCH 1/4] s390x: Split snippet makefile rules into new file Janosch Frank
2024-07-25 14:27 ` Christoph Schlameuss
2024-08-02 9:34 ` Janosch Frank [this message]
2024-07-25 14:35 ` Claudio Imbrenda
2024-07-18 10:50 ` [kvm-unit-tests PATCH 2/4] s390x/Makefile: Add more comments Janosch Frank
2024-07-25 14:30 ` Christoph Schlameuss
2024-07-25 14:34 ` Claudio Imbrenda
2024-07-18 10:50 ` [kvm-unit-tests PATCH 3/4] s390x: Move SIE assembly into new file Janosch Frank
2024-07-25 14:34 ` Christoph Schlameuss
2024-08-02 9:33 ` Janosch Frank
2024-08-02 13:21 ` Christoph Schlameuss
2024-07-25 14:36 ` Claudio Imbrenda
2024-07-18 10:50 ` [kvm-unit-tests PATCH 4/4] lib: s390x: Split SIE fw structs from lib structs Janosch Frank
2024-07-25 14:38 ` Christoph Schlameuss
2024-07-25 14:40 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f3bfc34-dbb1-4f49-bed3-bf373a9ac736@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=nsg@linux.ibm.com \
--cc=schlameuss@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox