From: Nagamani PV <nagamani@linux.ibm.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH net-next] s390/ctcm: Convert fsm.h to proper kernel-doc format
Date: Wed, 2 Sep 2026 14:27:36 +0530 [thread overview]
Message-ID: <3a4bd99a-ce48-4c7e-93b9-ac00d14e1a29@linux.ibm.com> (raw)
In-Reply-To: <20260804182758.C19221F000E9@smtp.kernel.org>
On 04/08/26 11:57 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] `fsm_deltimer()` uses non-sync `timer_delete()`, which can lead to a use-after-free when timers are freed during teardown.
> - [High] `fsm_addtimer()` unconditionally calls `timer_setup()`, which corrupts the timer wheel if the timer is already active.
Both findings confirmed, reviewed and validated. Note: the report
references ctcm_free_channel() which does not exist; the actual
teardown function is channel_remove() in ctcm_main.c.
Fixes will be submitted to netdev@vger.kernel.org shortly as a
two-patch series.
Nagamani
next prev parent reply other threads:[~2026-09-02 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 18:27 [PATCH net-next] s390/ctcm: Convert fsm.h to proper kernel-doc format Nagamani PV
2026-08-04 18:27 ` sashiko-bot
2026-09-02 8:57 ` Nagamani PV [this message]
2026-08-07 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a4bd99a-ce48-4c7e-93b9-ac00d14e1a29@linux.ibm.com \
--to=nagamani@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox