From: David Hildenbrand <david@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Janosch Frank <frankja@linux.vnet.ibm.com>,
KVM <kvm@vger.kernel.org>, Cornelia Huck <cohuck@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] KVM: s390: mark sie block as 512 byte aligned
Date: Mon, 16 Mar 2020 13:11:30 +0100 [thread overview]
Message-ID: <3b70e28f-a7d8-adfb-8f0b-de838d9c3b65@redhat.com> (raw)
In-Reply-To: <20200316131009.381a8692@p-imbrenda>
On 16.03.20 13:10, Claudio Imbrenda wrote:
> On Wed, 11 Mar 2020 09:33:04 +0100
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> The sie block must be aligned to 512 bytes. Mark it as such.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> arch/s390/include/asm/kvm_host.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/s390/include/asm/kvm_host.h
>> b/arch/s390/include/asm/kvm_host.h index 0ea82152d2f7..2d50f6c432e2
>> 100644 --- a/arch/s390/include/asm/kvm_host.h
>> +++ b/arch/s390/include/asm/kvm_host.h
>> @@ -344,7 +344,7 @@ struct kvm_s390_sie_block {
>> __u64 itdba; /* 0x01e8 */
>> __u64 riccbd; /* 0x01f0 */
>> __u64 gvrd; /* 0x01f8 */
>> -} __attribute__((packed));
>> +} __packed __aligned(512);
>>
>> struct kvm_s390_itdb {
>> __u8 data[256];
>
> I agree with the addition of aligned, but did you really have to remove
> packed? it makes me a little uncomfortable.
There is still "__packed".
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-16 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 8:33 [PATCH] KVM: s390: mark sie block as 512 byte aligned Christian Borntraeger
2020-03-11 8:41 ` David Hildenbrand
2020-03-11 10:37 ` Christian Borntraeger
2020-03-16 12:10 ` Claudio Imbrenda
2020-03-16 12:11 ` David Hildenbrand [this message]
2020-03-16 14:22 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b70e28f-a7d8-adfb-8f0b-de838d9c3b65@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox