From: Karsten Graul <kgraul@linux.ibm.com>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v3] net/smc: Don't call clcsock shutdown twice when smc shutdown
Date: Fri, 26 Nov 2021 10:04:29 +0100 [thread overview]
Message-ID: <3c6804b0-7f3a-0572-42f5-c72ca5dcdc46@linux.ibm.com> (raw)
In-Reply-To: <20211126024134.45693-1-tonylu@linux.alibaba.com>
On 26/11/2021 03:41, Tony Lu wrote:
> When applications call shutdown() with SHUT_RDWR in userspace,
> smc_close_active() calls kernel_sock_shutdown(), and it is called
> twice in smc_shutdown().
>
> This fixes this by checking sk_state before do clcsock shutdown, and
> avoids missing the application's call of smc_shutdown().
>
> Link: https://lore.kernel.org/linux-s390/1f67548e-cbf6-0dce-82b5-10288a4583bd@linux.ibm.com/
> Fixes: 606a63c9783a ("net/smc: Ensure the active closing peer first closes clcsock")
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
> ---
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2021-11-26 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 2:41 [PATCH net v3] net/smc: Don't call clcsock shutdown twice when smc shutdown Tony Lu
2021-11-26 9:04 ` Karsten Graul [this message]
2021-11-26 19:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c6804b0-7f3a-0572-42f5-c72ca5dcdc46@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox