From: Janosch Frank <frankja@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.vnet.ibm.com>
Cc: KVM <kvm@vger.kernel.org>, Cornelia Huck <cohuck@redhat.com>,
David Hildenbrand <david@redhat.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Thomas Huth <thuth@redhat.com>, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH 1/2] selftests: KVM: s390: fixup fprintf format error in reset.c
Date: Wed, 11 Mar 2020 15:02:04 +0100 [thread overview]
Message-ID: <3e093eca-9786-8aff-707f-f8529e3affd8@linux.ibm.com> (raw)
In-Reply-To: <20200311131056.140016-2-borntraeger@de.ibm.com>
[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]
On 3/11/20 2:10 PM, Christian Borntraeger wrote:
> value is u64 and not string.
>
> Reported-by: Andrew Jones <drjones@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> tools/testing/selftests/kvm/s390x/resets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/s390x/resets.c b/tools/testing/selftests/kvm/s390x/resets.c
> index b567705f0d41..221e9c9a8bd2 100644
> --- a/tools/testing/selftests/kvm/s390x/resets.c
> +++ b/tools/testing/selftests/kvm/s390x/resets.c
> @@ -66,7 +66,7 @@ static void test_one_reg(uint64_t id, uint64_t value)
> reg.addr = (uintptr_t)&eval_reg;
> reg.id = id;
> vcpu_get_reg(vm, VCPU_ID, ®);
> - TEST_ASSERT(eval_reg == value, "value == %s", value);
> + TEST_ASSERT(eval_reg == value, "value == 0x%lx", value);
> }
>
> static void assert_noirq(void)
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-11 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 13:10 [PATCH 0/2] format string fixups for selftests Christian Borntraeger
2020-03-11 13:10 ` [PATCH 1/2] selftests: KVM: s390: fixup fprintf format error in reset.c Christian Borntraeger
2020-03-11 14:02 ` Janosch Frank [this message]
2020-03-11 13:10 ` [PATCH 2/2] selftests: KVM: s390: fix format strings for access reg test Christian Borntraeger
2020-03-11 14:03 ` Janosch Frank
2020-03-11 14:07 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e093eca-9786-8aff-707f-f8529e3affd8@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox