From: Alexandra Winter <wintera@linux.ibm.com>
To: Dawei Li <dawei.li@shingroup.cn>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, ioana.ciornei@nxp.com, twinkler@linux.ibm.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net/iucv: Avoid explicit cpumask var allocation on stack
Date: Tue, 2 Apr 2024 14:41:24 +0200 [thread overview]
Message-ID: <4110b0fb-0005-45b6-9996-978b9bab8beb@linux.ibm.com> (raw)
In-Reply-To: <20240331053441.1276826-2-dawei.li@shingroup.cn>
On 31.03.24 07:34, Dawei Li wrote:
> For CONFIG_CPUMASK_OFFSTACK=y kernel, explicit allocation of cpumask
> variable on stack is not recommended since it can cause potential stack
> overflow.
>
> Instead, kernel code should always use *cpumask_var API(s) to allocate
> cpumask var in config-neutral way, leaving allocation strategy to
> CONFIG_CPUMASK_OFFSTACK.
>
> Use *cpumask_var API(s) to address it.
>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
> ---
LGTM;
Thank you Eric for the comment and solution with the 'static' keyword.
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
next prev parent reply other threads:[~2024-04-02 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-31 5:34 [PATCH net-next v2 0/2] Avoid explicit cpumask var allocation on stack Dawei Li
2024-03-31 5:34 ` Dawei Li
2024-03-31 5:34 ` [PATCH net-next v2 1/2] net/iucv: " Dawei Li
2024-03-31 5:34 ` Dawei Li
2024-04-02 12:41 ` Alexandra Winter [this message]
2024-03-31 5:34 ` [PATCH net-next v2 2/2] net/dpaa2: " Dawei Li
2024-03-31 5:34 ` Dawei Li
2024-04-03 1:40 ` [PATCH net-next v2 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4110b0fb-0005-45b6-9996-978b9bab8beb@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=dawei.li@shingroup.cn \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=twinkler@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox