Re: [PATCH v4 4/4] fixup! selftests: kvm: s390: Add VM run test case

[Janosch Frank <frankja@linux.ibm.com>]

On 9/17/24 8:44 AM, Christoph Schlameuss wrote:
> Fix pointer function arguments whitespaces.
> 
> Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>

Generally we don't use the fixup prefix in upstream development AFAIK.


selftests: kvm: s390: Fix whitespace confusion in ucontrol test

Checkpatch thinks that we're doing a multiplication but we're obviously 
not. Fix 4 instances where we adhered to wrong checkpatch advice.



Let's wait and see if the first set of patches is being pulled, if not 
we can still fix it up in the earlier patches making this patch obsolete.

> ---
>   tools/testing/selftests/kvm/s390x/ucontrol_test.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/s390x/ucontrol_test.c b/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> index 1f1c58f5ec2f..83061db79c83 100644
> --- a/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> +++ b/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> @@ -330,7 +330,7 @@ static void uc_handle_exit_ucontrol(FIXTURE_DATA(uc_kvm) *self)
>    * * fail on codes not expected in the test cases
>    * Returns if interception is handled / execution can be continued
>    */
> -static bool uc_handle_sieic(FIXTURE_DATA(uc_kvm) * self)
> +static bool uc_handle_sieic(FIXTURE_DATA(uc_kvm) *self)
>   {
>   	struct kvm_s390_sie_block *sie_block = self->sie_block;
>   	struct kvm_run *run = self->run;
> @@ -359,7 +359,7 @@ static bool uc_handle_sieic(FIXTURE_DATA(uc_kvm) * self)
>   }
>   
>   /* verify VM state on exit */
> -static bool uc_handle_exit(FIXTURE_DATA(uc_kvm) * self)
> +static bool uc_handle_exit(FIXTURE_DATA(uc_kvm) *self)
>   {
>   	struct kvm_run *run = self->run;
>   
> @@ -379,7 +379,7 @@ static bool uc_handle_exit(FIXTURE_DATA(uc_kvm) * self)
>   }
>   
>   /* run the VM until interrupted */
> -static int uc_run_once(FIXTURE_DATA(uc_kvm) * self)
> +static int uc_run_once(FIXTURE_DATA(uc_kvm) *self)
>   {
>   	int rc;
>   
> @@ -390,7 +390,7 @@ static int uc_run_once(FIXTURE_DATA(uc_kvm) * self)
>   	return rc;
>   }
>   
> -static void uc_assert_diag44(FIXTURE_DATA(uc_kvm) * self)
> +static void uc_assert_diag44(FIXTURE_DATA(uc_kvm) *self)
>   {
>   	struct kvm_s390_sie_block *sie_block = self->sie_block;
>