From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: vfio-ap: fix some comments
Date: Wed, 13 Nov 2019 13:15:15 +0100 [thread overview]
Message-ID: <42f63f2b-2fc7-4a68-a86b-886f6a4efc04@linux.ibm.com> (raw)
In-Reply-To: <20191113095319.6154-1-cohuck@redhat.com>
:) thanks,
Regards,
Pierre
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
On 2019-11-13 10:53, Cornelia Huck wrote:
> The functions are called vfio_ap_irq_{en,dis}able.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>
> Just some minor stuff I noted while grepping for something.
>
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
> index 5c0f53c6dde7..f8f3f3a4e5fd 100644
> --- a/drivers/s390/crypto/vfio_ap_ops.c
> +++ b/drivers/s390/crypto/vfio_ap_ops.c
> @@ -182,7 +182,7 @@ struct ap_queue_status vfio_ap_irq_disable(struct vfio_ap_queue *q)
> }
>
> /**
> - * vfio_ap_setirq: Enable Interruption for a APQN
> + * vfio_ap_irq_enable: Enable Interruption for a APQN
> *
> * @dev: the device associated with the ap_queue
> * @q: the vfio_ap_queue holding AQIC parameters
> @@ -265,7 +265,7 @@ static struct ap_queue_status vfio_ap_irq_enable(struct vfio_ap_queue *q,
> * - AP_RESPONSE_Q_NOT_AVAIL: if the queue is not available
> * - AP_RESPONSE_DECONFIGURED: if the queue is not configured
> * - AP_RESPONSE_NORMAL (0) : in case of successs
> - * Check vfio_ap_setirq() and vfio_ap_clrirq() for other possible RC.
> + * Check vfio_ap_irq_enable() and vfio_ap_irq_disable() for other possible RC.
> * We take the matrix_dev lock to ensure serialization on queues and
> * mediated device access.
> *
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2019-11-13 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:53 [PATCH] s390: vfio-ap: fix some comments Cornelia Huck
2019-11-13 12:15 ` Pierre Morel [this message]
2020-04-29 14:52 ` Tony Krowiak
2020-04-29 15:15 ` Tony Krowiak
2019-11-13 14:29 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f63f2b-2fc7-4a68-a86b-886f6a4efc04@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox