From: Alexandra Winter <wintera@linux.ibm.com>
To: Xu Wang <vulab@iscas.ac.cn>,
wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
borntraeger@linux.ibm.com, agordeev@linux.ibm.com
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/qeth: Remove redundant 'flush_workqueue()' calls
Date: Fri, 14 Jan 2022 12:58:38 +0100 [thread overview]
Message-ID: <45b2b8d0-b913-20cd-62ca-e6014505632c@linux.ibm.com> (raw)
In-Reply-To: <20220114084218.42586-1-vulab@iscas.ac.cn>
On 14.01.22 09:42, Xu Wang wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/s390/net/qeth_l3_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
> index 9251ad276ee8..d2f422a9a4f7 100644
> --- a/drivers/s390/net/qeth_l3_main.c
> +++ b/drivers/s390/net/qeth_l3_main.c
> @@ -1961,7 +1961,6 @@ static void qeth_l3_remove_device(struct ccwgroup_device *cgdev)
> if (card->dev->reg_state == NETREG_REGISTERED)
> unregister_netdev(card->dev);
>
> - flush_workqueue(card->cmd_wq);
> destroy_workqueue(card->cmd_wq);
> qeth_l3_clear_ip_htable(card, 0);
> qeth_l3_clear_ipato_list(card);
Thanks for pointing this out!
IMO, this can go to net-next as it is not a fix, but removes redundancy.
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
next prev parent reply other threads:[~2022-01-14 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 8:42 [PATCH] s390/qeth: Remove redundant 'flush_workqueue()' calls Xu Wang
2022-01-14 11:58 ` Alexandra Winter [this message]
2022-01-15 2:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45b2b8d0-b913-20cd-62ca-e6014505632c@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox