From: Alexandra Winter <wintera@linux.ibm.com>
To: Julian Ruess <julianr@linux.ibm.com>,
schnelle@linux.ibm.com, ts@linux.ibm.com, oberpar@linux.ibm.com,
gbayer@linux.ibm.com
Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com,
hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com,
linux390-list@tuxmaker.boeblingen.de.ibm.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 3/4] dibs: introduce dibs console peer device driver
Date: Tue, 17 Nov 2026 17:22:03 +0100 [thread overview]
Message-ID: <47f5f00c-e3bd-40ae-93be-65d4a5f2cc21@linux.ibm.com> (raw)
In-Reply-To: <20261008-console_server-v1-3-636b11ebf191@linux.ibm.com>
Just a few comments I noticed. I will continue the review at a later
point in time or a future version.
Title?
s/dibs console peer device driver/dibs console driver/g ?
On 08.10.26 10:08, Julian Ruess wrote:
> Introduce a virtual console device driver that makes use of the newly
> added dibs peer device bus.
s/dibs peer device bus/dibs peer bus/g use the same name everywhere!
[...]
> diff --git a/drivers/dibs/dibs_console.c b/drivers/dibs/dibs_console.c
> new file mode 100644
> index 000000000000..df53cbcf2fb5
> --- /dev/null
> +++ b/drivers/dibs/dibs_console.c
> @@ -0,0 +1,388 @@
[...]
> +
> +struct dibs_con_peer_dev *hvc_peer_devs[DIBS_CON_MAX_VTERMNOS] = { NULL };
I get a compile warning:
drivers/dibs/dibs_console.c:88:26: warning: symbol 'hvc_peer_devs' was
not declared. Should it be static?
next prev parent reply other threads:[~2026-11-17 16:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:08 [PATCH 0/4] Introduce dibs peer bus driver, dibs console and dibs block device driver Julian Ruess
2026-10-08 8:08 ` [PATCH 1/4] dibs: introduce ring-buffer send/receive API Julian Ruess
2026-10-08 8:21 ` sashiko-bot
2026-10-09 20:47 ` Niklas Schnelle
2026-11-10 17:44 ` Alexandra Winter
2026-10-08 8:08 ` [PATCH 2/4] dibs: introduce dibs peer device bus driver Julian Ruess
2026-10-08 8:27 ` sashiko-bot
2026-11-13 16:30 ` Alexandra Winter
2026-11-17 16:21 ` Alexandra Winter
2026-10-08 8:08 ` [PATCH 3/4] dibs: introduce dibs console peer device driver Julian Ruess
2026-10-08 8:26 ` sashiko-bot
2026-11-17 16:22 ` Alexandra Winter [this message]
2026-10-08 8:08 ` [PATCH 4/4] dibs: introduce dibs block device " Julian Ruess
2026-10-08 8:30 ` sashiko-bot
2026-11-17 16:25 ` Alexandra Winter
2026-11-10 17:44 ` [PATCH 0/4] Introduce dibs peer bus driver, dibs console and dibs block " Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47f5f00c-e3bd-40ae-93be-65d4a5f2cc21@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=gbayer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=julianr@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux390-list@tuxmaker.boeblingen.de.ibm.com \
--cc=mjrosato@linux.ibm.com \
--cc=oberpar@linux.ibm.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=ts@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox