From: Karsten Graul <kgraul@linux.ibm.com>
To: netdev@vger.kernel.org
Cc: kuba@kernel.org, davem@davemloft.net, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, Tony Lu <tonylu@linux.alibaba.com>
Subject: Re: [PATCH net 1/2] net/smc: Keep smc_close_final rc during active close
Date: Thu, 25 Nov 2021 11:51:46 +0100 [thread overview]
Message-ID: <48002af6-63ca-edd3-dd71-b66032baeeb3@linux.ibm.com> (raw)
In-Reply-To: <20211125061932.74874-2-tonylu@linux.alibaba.com>
On 25/11/2021 07:19, Tony Lu wrote:
> When smc_close_final() returns error, the return code overwrites by
> kernel_sock_shutdown() in smc_close_active(). The return code of
> smc_close_final() is more important than kernel_sock_shutdown(), and it
> will pass to userspace directly.
>
> Fix it by keeping both return codes, if smc_close_final() raises an
> error, return it or kernel_sock_shutdown()'s.
>
> Link: https://lore.kernel.org/linux-s390/1f67548e-cbf6-0dce-82b5-10288a4583bd@linux.ibm.com/
> Fixes: 606a63c9783a ("net/smc: Ensure the active closing peer first closes clcsock")
> Suggested-by: Karsten Graul <kgraul@linux.ibm.com>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
> Reviewed-by: Wen Gu <guwen@linux.alibaba.com>
> ---
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2021-11-25 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 6:19 [PATCH net 0/2] Fixes for clcsock shutdown behaviors Tony Lu
2021-11-25 6:19 ` [PATCH net 1/2] net/smc: Keep smc_close_final rc during active close Tony Lu
2021-11-25 10:51 ` Karsten Graul [this message]
2021-11-25 6:19 ` [PATCH net 2/2] net/smc: Don't call clcsock shutdown twice when smc shutdown Tony Lu
2021-11-25 11:02 ` Karsten Graul
2021-11-25 12:41 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48002af6-63ca-edd3-dd71-b66032baeeb3@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox