From: Jens Axboe <axboe@kernel.dk>
To: Stefan Haberland <sth@linux.ibm.com>
Cc: linux-block@vger.kernel.org, hoeppner@linux.ibm.com,
linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com
Subject: Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
Date: Tue, 7 Apr 2020 12:24:31 -0700 [thread overview]
Message-ID: <4a51ce19-7827-5ee6-8b06-5b814bdf503a@kernel.dk> (raw)
In-Reply-To: <c7ac9c3c-3a1f-3ce3-acbd-422bc4206288@linux.ibm.com>
On 4/7/20 3:01 AM, Stefan Haberland wrote:
> Am 06.04.20 um 17:32 schrieb Jens Axboe:
>> On 4/6/20 1:41 AM, Stefan Haberland wrote:
>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
>>> remove legacy IO schedulers").
>> Isn't this a leftover thing from when dasd selected deadline
>> internally? I don't think we need this anymore, just kill the
>> select completely.
>>
>
> Basically yes.
> We still have the recommendation to use deadline and there are some udev
> rules in place which select it.
> So I thought it might be a good idea to keep the line. But I am also
> fine to drop it completely if you prefer this.
I don't feel super strongly about it, but at the same time I don't
think there's a reason for it. Besides, I think everyone has deadline
enabled. So I guess we should just kill it.
--
Jens Axboe
next prev parent reply other threads:[~2020-04-07 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 7:41 [PATCH 0/1] s390/dasd: Kconfig patch Stefan Haberland
2020-04-06 7:41 ` [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE Stefan Haberland
2020-04-06 15:32 ` Jens Axboe
2020-04-07 10:01 ` Stefan Haberland
2020-04-07 19:24 ` Jens Axboe [this message]
2020-04-15 9:18 ` Stefan Haberland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a51ce19-7827-5ee6-8b06-5b814bdf503a@kernel.dk \
--to=axboe@kernel.dk \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox