From: Matthew Rosato <mjrosato@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 07/10] vfio/ccw: Create an OPEN FSM Event
Date: Thu, 16 Jun 2022 13:18:58 -0400 [thread overview]
Message-ID: <4e5d8991-ffd6-7a7d-a8a9-8c2a2211728e@linux.ibm.com> (raw)
In-Reply-To: <a1fd40e16fd4feb88b3f538e02319267d6901475.camel@linux.ibm.com>
>> As for the IDLE/CP_PROCESSING/CP_PENDING cases, going fsm_notoper
>> because this is unexpected probably makes sense, but the logging is
>> going to be really confusing (before this change, you know that you
>> called fsm_notoper because you got VFIO_CCW_EVENT_NOT_OPER -- now
>> you'll
>> see a log entry cut for NOT_OPER but won't be sure if it was for
>> EVENT_NOT_OPER or EVENT_OPEN). Maybe you can look at 'event' inside
>> fsm_notoper and cut a slightly different trace entry when arriving
>> here
>> for EVENT_OPEN?
>
> Yeah, good idea. Since we don't expect any of these in normal behavior,
> perhaps I'll trace both state and event, instead of trying to make
> conditionals out of everything.
>
Sounds good to me
next prev parent reply other threads:[~2022-06-16 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 20:33 [PATCH v2 00/10] s390/vfio-ccw rework Eric Farman
2022-06-15 20:33 ` [PATCH v2 01/10] vfio/ccw: Remove UUID from s390 debug log Eric Farman
2022-06-15 20:57 ` Kirti Wankhede
2022-06-15 20:33 ` [PATCH v2 02/10] vfio/ccw: Fix FSM state if mdev probe fails Eric Farman
2022-06-15 20:33 ` [PATCH v2 03/10] vfio/ccw: Do not change FSM state in subchannel event Eric Farman
2022-06-16 15:35 ` Matthew Rosato
2022-06-16 17:13 ` Eric Farman
2022-06-15 20:33 ` [PATCH v2 04/10] vfio/ccw: Remove private->mdev Eric Farman
2022-06-16 15:36 ` Matthew Rosato
2022-06-23 14:59 ` Jason Gunthorpe
2022-06-15 20:33 ` [PATCH v2 05/10] vfio/ccw: Pass enum to FSM event jumptable Eric Farman
2022-06-15 20:33 ` [PATCH v2 06/10] vfio/ccw: Flatten MDEV device (un)register Eric Farman
2022-06-15 20:33 ` [PATCH v2 07/10] vfio/ccw: Create an OPEN FSM Event Eric Farman
2022-06-16 16:33 ` Matthew Rosato
2022-06-16 17:14 ` Eric Farman
2022-06-16 17:18 ` Matthew Rosato [this message]
2022-06-15 20:33 ` [PATCH v2 08/10] vfio/ccw: Create a CLOSE FSM event Eric Farman
2022-06-16 16:48 ` Matthew Rosato
2022-06-15 20:33 ` [PATCH v2 09/10] vfio/ccw: Refactor vfio_ccw_mdev_reset Eric Farman
2022-06-15 20:33 ` [PATCH v2 10/10] vfio/ccw: Move FSM open/close to MDEV open/close Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5d8991-ffd6-7a7d-a8a9-8c2a2211728e@linux.ibm.com \
--to=mjrosato@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=farman@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox