From: Markus Elfring <Markus.Elfring@web.de>
To: "Triet Hoang" <triet.hoang.dev@gmail.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Bornträger" <borntraeger@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Kees Cook <kees@kernel.org>
Subject: Re: [PATCH v2] s390: raw3270: Handle allocation failures
Date: Wed, 19 Aug 2026 07:45:29 +0200 [thread overview]
Message-ID: <50599d8d-6c06-423a-8cbc-6866d59906fa@web.de> (raw)
In-Reply-To: <20260818073205.1669781-1-triet.hoang.dev@gmail.com>
> Check the return values of kzalloc_obj() and kzalloc() before using the
> allocated memory. Free the allocated resources on subsequent initialization
> failures to avoid leaking memory.
* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2#n145
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.2#n34
* Please avoid duplicate source code also for an improved implementation of
the function “raw3270_setup_console”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.2#n526
https://elixir.bootlin.com/linux/v7.2/source/drivers/s390/char/raw3270.c#L802-L839
* How do you think about to increase the application of scope-based resource management?
Regards,
Markus
prev parent reply other threads:[~2026-08-19 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 7:32 [PATCH v2] s390: raw3270: Handle allocation failures Triet Hoang
2026-08-18 7:45 ` sashiko-bot
2026-08-19 5:45 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50599d8d-6c06-423a-8cbc-6866d59906fa@web.de \
--to=markus.elfring@web.de \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kees@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=triet.hoang.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox