From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Andy Lutomirski <luto@amacapital.net>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
"linux390@de.ibm.com" <linux390@de.ibm.com>
Subject: Re: [virtio-dev] Re: [PATCH v2 0/4] virtio: Clean up scatterlists and use the DMA API
Date: Thu, 28 Aug 2014 21:18:46 +0200 [thread overview]
Message-ID: <53FF8096.6020005@de.ibm.com> (raw)
In-Reply-To: <CALCETrUb__cfwx1N-ZrrYJz0ffvD8jgRPwXOY3_oSb-8MCb3-Q@mail.gmail.com>
On 28/08/14 21:03, Andy Lutomirski wrote:
> [removed virtio-dev -- I'm sick of bounces]
>
> On Thu, Aug 28, 2014 at 11:55 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 28/08/2014 20:29, Christian Borntraeger ha scritto:
>>>>>>> block seems to work, with net a simple ping works, iperf causes this:
>>>>>
>>>>> I neither see the bug, nor can I reproduce it on x86_64 on KVM. I
>>>>> doubt that dma vs. non-dma is relevant. I tried -net user a -net tap
>>>>> with iperf running in both directions. I also tried switching
>>>>> virtio_pci into non-DMA-API mode. No errors.
>>>>>
>>>>> Is there any chance that you could instrument that BUG_ON to print n,
>>>>> i, in_sgs, out_sgs, total_sg, total_in, and total_out? I assume this
>>>>> is some oddity with patch 1, but I'm mystified.
>>> Yes, its triggered by patch 1.
>>
>> What version of QEMU? Can you two cat the "features" file in the
>> virtio-net device's sysfs directory?
>
> With vhost=on:
>
> # cat /sys/class/net/eth0/device/features
> 0000011000000001111101010001110000000000000000000000000000000000
>
> Without vhost=on:
>
> # cat /sys/class/net/eth0/device/features
> 0000011000000001111101010001110000000000000000000000000000000000
>
> Instrumenting the code says that indirect=1.
>
> --Andy
>
I have
1100011111111111111101010001110000000000000000000000000000000000
next prev parent reply other threads:[~2014-08-28 19:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 21:50 [PATCH v2 0/4] virtio: Clean up scatterlists and use the DMA API Andy Lutomirski
2014-08-27 21:50 ` [PATCH v2 1/4] virtio_ring: Remove sg_next indirection Andy Lutomirski
2014-08-27 21:50 ` [PATCH v2 2/4] virtio_ring: Support DMA APIs if requested Andy Lutomirski
2014-08-27 21:50 ` [PATCH v2 3/4] virtio_pci: Use the DMA API for virtqueues Andy Lutomirski
2014-08-27 21:50 ` [PATCH v2 4/4] virtio_net: Stop doing DMA from the stack Andy Lutomirski
2014-08-28 7:44 ` [PATCH v2 0/4] virtio: Clean up scatterlists and use the DMA API Christian Borntraeger
[not found] ` <53FEDDF5.3030903@de.ibm.com>
2014-08-28 18:06 ` Andy Lutomirski
2014-08-28 18:29 ` Christian Borntraeger
[not found] ` <53FF751D.2040006@de.ibm.com>
2014-08-28 18:51 ` Andy Lutomirski
2014-08-28 19:09 ` Christian Borntraeger
2014-08-28 18:55 ` [virtio-dev] " Paolo Bonzini
[not found] ` <53FF7B1A.2050307@redhat.com>
2014-08-28 19:03 ` Andy Lutomirski
2014-08-28 19:18 ` Christian Borntraeger [this message]
2014-08-28 21:16 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF8096.6020005@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=luto@amacapital.net \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox