From: Janosch Frank <frankja@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>, linux-s390@vger.kernel.org
Cc: "Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Nico Böhr" <nrb@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/2] s390x: Only run genprotimg if necessary
Date: Mon, 3 Jun 2024 13:54:07 +0200 [thread overview]
Message-ID: <5b63cc59-88ec-45a6-947f-7f44e8e0bbf3@linux.ibm.com> (raw)
In-Reply-To: <20240602130656.120866-2-npiggin@gmail.com>
On 6/2/24 15:06, Nicholas Piggin wrote:
> genprotimg is not required if the --host-key-document= configure option
> is not specified, so avoid running it in that case. This prevents the
> build message:
>
> bash: line 1: genprotimg: command not found
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
This solves the immediate problem but I think we're really missing a lot
more checks in the makefile and configure to sanitize the SE option space.
Anyway:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2024-06-03 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 13:06 [kvm-unit-tests PATCH 0/2] s390x: Fix build error messages Nicholas Piggin
2024-06-02 13:06 ` [kvm-unit-tests PATCH 1/2] s390x: Only run genprotimg if necessary Nicholas Piggin
2024-06-03 11:54 ` Janosch Frank [this message]
2024-06-04 5:18 ` Nicholas Piggin
2024-06-02 13:06 ` [kvm-unit-tests PATCH 2/2] s390x: Specify program headers with flags to avoid linker warnings Nicholas Piggin
2024-06-04 5:32 ` [kvm-unit-tests PATCH 0/2] s390x: Fix build error messages Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b63cc59-88ec-45a6-947f-7f44e8e0bbf3@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox