From: Gerd Bayer <gbayer@linux.ibm.com>
To: Paolo Abeni <pabeni@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>, Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>
Cc: Wenjia Zhang <wenjia@linux.ibm.com>,
Wen Gu <guwen@linux.alibaba.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
Alexandra Winter <wintera@linux.ibm.com>,
Thorsten Winkler <twinkler@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
pasic@linux.ibm.com, schnelle@linux.ibm.com
Subject: Re: [PATCH net] Revert "s390/ism: fix receive message buffer allocation"
Date: Thu, 11 Apr 2024 11:13:53 +0200 [thread overview]
Message-ID: <60455a55f6595b9ac0fe8922a162b5727556d85a.camel@linux.ibm.com> (raw)
In-Reply-To: <facf085f326813ec12566b3458650746e0267aca.camel@redhat.com>
On Thu, 2024-04-11 at 09:16 +0200, Paolo Abeni wrote:
> Hi,
>
> On Tue, 2024-04-09 at 13:37 +0200, Gerd Bayer wrote:
> > This reverts commit 58effa3476536215530c9ec4910ffc981613b413.
> > Review was not finished on this patch. So it's not ready for
> > upstreaming.
> >
> > Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
>
> It's not a big deal (no need to repost), but should the need arise
> again in the future it would be better explicitly marking the
> reverted commit in the tag area as 'Fixes'. The full hash in the
> commit message will likely save the day to stable teams, but better
> safe then sorry!
Thanks Paolo for the explanation. I was not even sure if the commit
hash of the erroneous commit will remain stable when this tree will be
merged upstream. In my (naive?) view this could be "autosquashed" into
nothing at the time of the merge.
But since there appears to be time for the next pull request to
upstream, I'll send a new version of the original patch with all the
review comments addressed.
Thanks again,
Gerd
next prev parent reply other threads:[~2024-04-11 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 11:37 [PATCH net] Revert "s390/ism: fix receive message buffer allocation" Gerd Bayer
2024-04-11 7:16 ` Paolo Abeni
2024-04-11 9:13 ` Gerd Bayer [this message]
2024-04-11 13:52 ` Simon Horman
2024-04-11 7:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60455a55f6595b9ac0fe8922a162b5727556d85a.camel@linux.ibm.com \
--to=gbayer@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=hch@lst.de \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox