From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>,
Nico Boehr <nrb@linux.ibm.com>
Cc: hca@linux.ibm.com, gor@linux.ibm.com, svens@linux.ibm.com,
linux-s390@vger.kernel.org, mhartmay@linux.ibm.com
Subject: Re: [PATCH v1] s390: ipl: fix physical-virtual confusion for diag308
Date: Fri, 10 Mar 2023 14:20:32 +0100 [thread overview]
Message-ID: <64918275-3f63-68c5-1c82-ff2b60114662@linux.ibm.com> (raw)
In-Reply-To: <ZAslxw+V0FY9bYLF@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com>
Am 10.03.23 um 13:42 schrieb Alexander Gordeev:
> On Fri, Mar 10, 2023 at 01:34:27PM +0100, Alexander Gordeev wrote:
>>> Note that several callers pass NULL as addr, this is fine since
>>> virt_to_phys(0) == 0.
>
> Missed that.
>
> Are you sure? Quickly checked ppc64, x86 and arm64 - they do not
> seem adhere virt_to_phys(0) == 0, nor the VR kernel (so far).
Isnt that the prefix page? I think we did say that the prefix page must be 0 in virt and phys otherwise we will have performance issues due to cache synonyms.
next prev parent reply other threads:[~2023-03-10 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 12:22 [PATCH v1] s390: ipl: fix physical-virtual confusion for diag308 Nico Boehr
2023-03-10 12:34 ` Alexander Gordeev
2023-03-10 12:42 ` Alexander Gordeev
2023-03-10 13:05 ` Nico Boehr
2023-03-10 13:20 ` Christian Borntraeger [this message]
2023-03-10 13:31 ` Alexander Gordeev
2023-03-10 13:37 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64918275-3f63-68c5-1c82-ff2b60114662@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox