From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check
Date: Thu, 18 Feb 2021 09:32:31 +0100 [thread overview]
Message-ID: <654d87bc-9d2c-9a14-6112-563b035331b3@redhat.com> (raw)
In-Reply-To: <20210218082449.29876-1-frankja@linux.ibm.com>
On 18.02.21 09:24, Janosch Frank wrote:
> Turns out that partition numbers start from 0 and not from 1 so a 0
> check doesn't make sense here.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> s390x/sthyi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/s390x/sthyi.c b/s390x/sthyi.c
> index d8dfc854..db90b56f 100644
> --- a/s390x/sthyi.c
> +++ b/s390x/sthyi.c
> @@ -128,7 +128,6 @@ static void test_fcode0_par(struct sthyi_par_sctn *par)
> report(sum, "core counts");
>
> if (par->INFPVAL1 & PART_STSI_SUC) {
> - report(par->INFPPNUM, "number");
> report(memcmp(par->INFPPNAM, null_buf, sizeof(par->INFPPNAM)),
> "name");
> }
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-02-18 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 8:24 [kvm-unit-tests PATCH] s390x: Remove sthyi partition number check Janosch Frank
2021-02-18 8:32 ` David Hildenbrand [this message]
2021-02-18 8:51 ` Cornelia Huck
2021-02-18 14:54 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=654d87bc-9d2c-9a14-6112-563b035331b3@redhat.com \
--to=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox