From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
kvm@vger.kernel.org
Cc: cohuck@redhat.com, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 3/3] s390x: run: Skip PV tests when tcg is the accelerator
Date: Mon, 7 Jun 2021 11:57:42 +0200 [thread overview]
Message-ID: <656f9301-70ec-a1e1-2d24-48ede0b07aca@redhat.com> (raw)
In-Reply-To: <92be69b9-227a-d01c-6877-738a4482b8c6@redhat.com>
On 07.06.21 11:54, Thomas Huth wrote:
> On 18/03/2021 13.50, Janosch Frank wrote:
>> TCG doesn't support PV.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> s390x/run | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/s390x/run b/s390x/run
>> index df7ef5ca..82922701 100755
>> --- a/s390x/run
>> +++ b/s390x/run
>> @@ -19,6 +19,11 @@ else
>> ACCEL=$DEF_ACCEL
>> fi
>>
>> +if [ "${1: -7}" == ".pv.bin" ] || [ "${TESTNAME: -3}" == "_PV" ] && [ $ACCEL == "tcg" ]; then
>
> Put $ACCEL in quotes?
>
> With that nit fixed:
>
Should these "==" be "=" ? Bash string comparisons always mess with my mind.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-06-07 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:50 [kvm-unit-tests PATCH 0/3] scripts: Fix PV run handling Janosch Frank
2021-03-18 12:50 ` [kvm-unit-tests PATCH 1/3] s390x: Don't run PV testcases under tcg Janosch Frank
2021-06-07 9:46 ` Thomas Huth
2021-06-07 9:55 ` David Hildenbrand
2021-03-18 12:50 ` [kvm-unit-tests PATCH 2/3] configure: s390x: Check if the host key document exists Janosch Frank
2021-06-07 9:48 ` Thomas Huth
2021-06-07 9:56 ` David Hildenbrand
2021-03-18 12:50 ` [kvm-unit-tests PATCH 3/3] s390x: run: Skip PV tests when tcg is the accelerator Janosch Frank
2021-06-07 9:54 ` Thomas Huth
2021-06-07 9:57 ` David Hildenbrand [this message]
2021-06-07 10:02 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=656f9301-70ec-a1e1-2d24-48ede0b07aca@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox