From: Karsten Graul <kgraul@linux.ibm.com>
To: Wen Gu <guwen@linux.alibaba.com>, davem@davemloft.net, kuba@kernel.org
Cc: linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/2] net/smc: Two fixes for smc fallback
Date: Sat, 23 Apr 2022 12:26:43 +0200 [thread overview]
Message-ID: <67d3e987-47ba-160f-ed73-0dfe1e92c513@linux.ibm.com> (raw)
In-Reply-To: <1650614179-11529-1-git-send-email-guwen@linux.alibaba.com>
On 22/04/2022 09:56, Wen Gu wrote:
> This patch set includes two fixes for smc fallback:
>
> Patch 1/2 introduces some simple helpers to wrap the replacement
> and restore of clcsock's callback functions. Make sure that only
> the original callbacks will be saved and not overwritten.
>
> Patch 2/2 fixes a syzbot reporting slab-out-of-bound issue where
> smc_fback_error_report() accesses the already freed smc sock (see
> https://lore.kernel.org/r/00000000000013ca8105d7ae3ada@google.com/).
> The patch fixes it by resetting sk_user_data and restoring clcsock
> callback functions timely in fallback situation.
Thank you for the analysis and the fix!
For the series:
Acked-by: Karsten Graul <kgraul@linux.ibm.com>
next prev parent reply other threads:[~2022-04-23 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 7:56 [PATCH net 0/2] net/smc: Two fixes for smc fallback Wen Gu
2022-04-22 7:56 ` [PATCH net 1/2] net/smc: Only save the original clcsock callback functions Wen Gu
2022-04-22 7:56 ` [PATCH net 2/2] net/smc: Fix slab-out-of-bounds issue in fallback Wen Gu
2022-04-23 10:26 ` Karsten Graul [this message]
2022-04-25 19:10 ` [PATCH net 0/2] net/smc: Two fixes for smc fallback patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d3e987-47ba-160f-ed73-0dfe1e92c513@linux.ibm.com \
--to=kgraul@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=guwen@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox