From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Yu Zhe <yuzhe@nfschina.com>,
freude@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH v3] s390/zcrypt: remove unnecessary (void*) conversions
Date: Fri, 3 Mar 2023 16:02:26 +0500 [thread overview]
Message-ID: <67d475aa-b999-bf57-3aa3-40ad4b50e21d@collabora.com> (raw)
In-Reply-To: <20230303052155.21072-1-yuzhe@nfschina.com>
On 3/3/23 10:21 AM, Yu Zhe wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> drivers/s390/crypto/zcrypt_msgtype6.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
> index 5ad251477593..a2e7fe33ba62 100644
> --- a/drivers/s390/crypto/zcrypt_msgtype6.c
> +++ b/drivers/s390/crypto/zcrypt_msgtype6.c
> @@ -926,8 +926,7 @@ static void zcrypt_msgtype6_receive(struct ap_queue *aq,
> .type = TYPE82_RSP_CODE,
> .reply_code = REP82_ERROR_MACHINE_FAILURE,
> };
> - struct response_type *resp_type =
> - (struct response_type *)msg->private;
> + struct response_type *resp_type = msg->private;
> struct type86x_reply *t86r;
> int len;
>
> @@ -982,8 +981,7 @@ static void zcrypt_msgtype6_receive_ep11(struct ap_queue *aq,
> .type = TYPE82_RSP_CODE,
> .reply_code = REP82_ERROR_MACHINE_FAILURE,
> };
> - struct response_type *resp_type =
> - (struct response_type *)msg->private;
> + struct response_type *resp_type = msg->private;
> struct type86_ep11_reply *t86r;
> int len;
>
> @@ -1157,7 +1155,7 @@ static long zcrypt_msgtype6_send_cprb(bool userspace, struct zcrypt_queue *zq,
> struct ap_message *ap_msg)
> {
> int rc;
> - struct response_type *rtype = (struct response_type *)(ap_msg->private);
> + struct response_type *rtype = ap_msg->private;
> struct {
> struct type6_hdr hdr;
> struct CPRBX cprbx;
> @@ -1240,7 +1238,7 @@ static long zcrypt_msgtype6_send_ep11_cprb(bool userspace, struct zcrypt_queue *
> {
> int rc;
> unsigned int lfmt;
> - struct response_type *rtype = (struct response_type *)(ap_msg->private);
> + struct response_type *rtype = ap_msg->private;
> struct {
> struct type6_hdr hdr;
> struct ep11_cprb cprbx;
> @@ -1359,7 +1357,7 @@ static long zcrypt_msgtype6_rng(struct zcrypt_queue *zq,
> short int verb_length;
> short int key_length;
> } __packed * msg = ap_msg->msg;
> - struct response_type *rtype = (struct response_type *)(ap_msg->private);
> + struct response_type *rtype = ap_msg->private;
> int rc;
>
> msg->cprbx.domain = AP_QID_QUEUE(zq->queue->qid);
--
BR,
Muhammad Usama Anjum
next prev parent reply other threads:[~2023-03-03 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:12 [PATCH] s390/zcrypt: remove unnecessary (void*) conversions Yu Zhe
2023-02-28 18:05 ` Heiko Carstens
2023-03-03 1:32 ` [PATCH v2] " Yu Zhe
2023-03-03 4:23 ` Dan Carpenter
2023-03-03 5:21 ` [PATCH v3] " Yu Zhe
2023-03-03 11:02 ` Muhammad Usama Anjum [this message]
2023-03-03 12:16 ` Dan Carpenter
2023-03-03 13:10 ` Harald Freudenberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d475aa-b999-bf57-3aa3-40ad4b50e21d@collabora.com \
--to=usama.anjum@collabora.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=svens@linux.ibm.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox