public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable
Date: Thu, 7 Oct 2021 10:14:24 +0200	[thread overview]
Message-ID: <6b4b6ae0-6cee-e435-189a-8657159de97f@linux.ibm.com> (raw)
In-Reply-To: <20211007072136.768459-1-thuth@redhat.com>

On 10/7/21 09:21, Thomas Huth wrote:
> The guest_instr variable is not used, which was likely a
> copy-n-paste issue from the s390x/sie.c test.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Janosch Fran <frankja@linux.ibm.com>
Thanks, picked.

Weird that the compiler didn't complain with a set but not used message...

> ---
>   s390x/mvpg-sie.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/s390x/mvpg-sie.c b/s390x/mvpg-sie.c
> index ccc273b..5adcec1 100644
> --- a/s390x/mvpg-sie.c
> +++ b/s390x/mvpg-sie.c
> @@ -21,7 +21,6 @@
>   #include <sie.h>
>   
>   static u8 *guest;
> -static u8 *guest_instr;
>   static struct vm vm;
>   
>   static uint8_t *src;
> @@ -94,8 +93,6 @@ static void setup_guest(void)
>   
>   	/* Allocate 1MB as guest memory */
>   	guest = alloc_pages(8);
> -	/* The first two pages are the lowcore */
> -	guest_instr = guest + PAGE_SIZE * 2;
>   
>   	sie_guest_create(&vm, (uint64_t)guest, HPAGE_SIZE);
>   
> 


      parent reply	other threads:[~2021-10-07  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07  7:21 [kvm-unit-tests PATCH] s390x/mvpg-sie: Remove unused variable Thomas Huth
2021-10-07  7:31 ` Claudio Imbrenda
2021-10-07  8:14 ` Janosch Frank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b4b6ae0-6cee-e435-189a-8657159de97f@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox