From: Eric Farman <farman@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
linux-s390@vger.kernel.org, Pierre Morel <pmorel@linux.ibm.com>,
kvm@vger.kernel.org, qemu-s390x@nongnu.org,
Farhan Ali <alifm@linux.ibm.com>,
qemu-devel@nongnu.org,
Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [qemu-s390x] [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs
Date: Thu, 11 Apr 2019 12:25:38 -0400 [thread overview]
Message-ID: <72385d8c-a050-67e7-85cf-bc804f941137@linux.ibm.com> (raw)
In-Reply-To: <20190411175831.7be345f4@oc2783563651>
On 4/11/19 11:58 AM, Halil Pasic wrote:
> On Wed, 10 Apr 2019 22:59:41 -0400
> Eric Farman <farman@linux.ibm.com> wrote:
>
>> r the next release :) It would be one thing less on my plate...
>>>>
>>>
>>> Sorry I was not able to spend any significant amount of time on this
>>> lately.
>>>
>>> Gave the combined set (this + Farhans fio-ccw fixes for kernel
>>> stacktraces v2) it a bit of smoke testing after some minor adjustments
>>> to make it compile:
>>>
>>> --- a/drivers/s390/cio/vfio_ccw_ops.c
>>> +++ b/drivers/s390/cio/vfio_ccw_ops.c
>>> @@ -13,6 +13,7 @@
>>> #include <linux/vfio.h>
>>> #include <linux/mdev.h>
>>> #include <linux/nospec.h>
>>> +#include <linux/slab.h>
>>>
>>> #include "vfio_ccw_private.h"
>>>
>>>
>>
>> Hrm... Taking today's master, and the two series you mention (slight
>> adjustment to apply patch 3 of Connie's series, because part of it was
>> split out a few weeks ago), and I don't encounter this. Tried switching
>> between SLUB/SLAB, but still compiles fine.
>
> Let me guess: you have CONFIG_PCI in our .config, right?
>
> In arch/s390/include/asm/pci_io.h we have
>
> #ifndef _ASM_S390_PCI_IO_H
> #define _ASM_S390_PCI_IO_H
>
> #ifdef CONFIG_PCI
>
> #include <linux/kernel.h>
> #include <linux/slab.h>
>
> and pci_io.h comes in via
>
> include/linux/vfio.h
> include/linux/iommu.h
> include/linux/scatterlist.h
> arch/s390/include/asm/io.h
> arch/s390/include/asm/pci_io.h
>
>
> Figured it out with help from Farhan. Took me quite some time.
That would have been useful information up front.
>
> Regards,
> Halil
>
>
next prev parent reply other threads:[~2019-04-11 16:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 9:38 [PATCH v4 0/6] vfio-ccw: support hsch/csch (kernel part) Cornelia Huck
2019-03-01 9:38 ` [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs Cornelia Huck
2019-04-08 17:02 ` Farhan Ali
2019-04-08 17:07 ` Cornelia Huck
2019-04-08 17:19 ` Farhan Ali
2019-04-08 20:25 ` Eric Farman
2019-04-09 23:34 ` [Qemu-devel] " Halil Pasic
2019-04-11 2:59 ` Eric Farman
2019-04-11 15:58 ` [qemu-s390x] " Halil Pasic
2019-04-11 16:25 ` Eric Farman [this message]
2019-04-11 16:36 ` Cornelia Huck
2019-04-11 18:07 ` Halil Pasic
2019-04-11 21:27 ` Eric Farman
2019-04-12 8:14 ` Cornelia Huck
2019-03-01 9:38 ` [PATCH v4 2/6] vfio-ccw: rework ssch state handling Cornelia Huck
2019-03-08 22:18 ` Eric Farman
2019-03-11 9:47 ` Cornelia Huck
2019-03-01 9:38 ` [PATCH v4 3/6] vfio-ccw: protect the I/O region Cornelia Huck
2019-03-01 9:39 ` [PATCH v4 4/6] vfio-ccw: add capabilities chain Cornelia Huck
2019-04-15 14:40 ` Eric Farman
2019-04-15 15:24 ` Farhan Ali
2019-03-01 9:39 ` [PATCH v4 5/6] s390/cio: export hsch to modules Cornelia Huck
2019-03-01 9:39 ` [PATCH v4 6/6] vfio-ccw: add handling for async channel instructions Cornelia Huck
2019-04-15 14:56 ` Eric Farman
2019-04-15 15:25 ` Farhan Ali
2019-03-07 21:28 ` [PATCH v4 0/6] vfio-ccw: support hsch/csch (kernel part) Eric Farman
2019-03-12 14:31 ` Cornelia Huck
2019-04-15 11:51 ` Cornelia Huck
2019-04-15 16:43 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72385d8c-a050-67e7-85cf-bc804f941137@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox