From: Guangguan Wang <guangguan.wang@linux.alibaba.com>
To: Jan Karcher <jaka@linux.ibm.com>,
wenjia@linux.ibm.com, kgraul@linux.ibm.com,
tonylu@linux.alibaba.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc: horms@kernel.org, alibuda@linux.alibaba.com,
guwen@linux.alibaba.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/6] net/smc: support max connections per lgr negotiation
Date: Thu, 17 Aug 2023 17:25:13 +0800 [thread overview]
Message-ID: <78348c02-6f5a-2d25-b417-089346f4d412@linux.alibaba.com> (raw)
In-Reply-To: <dcbb9692-0494-1161-d873-ef67b3e7cb6d@linux.ibm.com>
On 2023/8/17 14:42, Jan Karcher wrote:
>
>
> On 16/08/2023 10:33, Guangguan Wang wrote:
...
>> @@ -1163,6 +1173,11 @@ int smc_clc_srv_v2x_features_validate(struct smc_clc_msg_proposal *pclc,
>> {
>> struct smc_clc_v2_extension *pclc_v2_ext;
>> + /* default max conn is SMC_CONN_PER_LGR_MAX(255),
>> + * which is the default value in smc v1 and v2.0.
>> + */
>
> I'm afraid this comment is not going to age well. You already put this to the define itself so i plea to remove it here.
>
> Thank you.
> - Jan
>
Get it, Thanks.
next prev parent reply other threads:[~2023-08-17 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 8:33 [PATCH net-next 0/6] net/smc: several features's implementation for smc v2.1 Guangguan Wang
2023-08-16 8:33 ` [PATCH net-next 1/6] net/smc: support smc release version negotiation in clc handshake Guangguan Wang
2023-08-16 14:14 ` Jan Karcher
2023-08-17 3:18 ` Guangguan Wang
2023-08-17 6:42 ` Jan Karcher
2023-08-16 8:33 ` [PATCH net-next 2/6] net/smc: add vendor unique experimental options area " Guangguan Wang
2023-08-16 21:49 ` Jan Karcher
2023-08-17 3:23 ` Guangguan Wang
2023-08-16 8:33 ` [PATCH net-next 3/6] net/smc: support smc v2.x features validate Guangguan Wang
2023-08-16 12:49 ` Vadim Fedorenko
2023-08-17 3:31 ` Guangguan Wang
2023-08-17 6:42 ` Jan Karcher
2023-08-17 9:25 ` Guangguan Wang
2023-08-16 8:33 ` [PATCH net-next 4/6] net/smc: support max connections per lgr negotiation Guangguan Wang
2023-08-17 6:42 ` Jan Karcher
2023-08-17 9:25 ` Guangguan Wang [this message]
2023-08-16 8:33 ` [PATCH net-next 5/6] net/smc: support max links per lgr negotiation in clc handshake Guangguan Wang
2023-08-16 8:33 ` [PATCH net-next 6/6] net/smc: Extend SMCR v2 linkgroup netlink attribute Guangguan Wang
2023-08-17 6:43 ` [PATCH net-next 0/6] net/smc: several features's implementation for smc v2.1 Jan Karcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78348c02-6f5a-2d25-b417-089346f4d412@linux.alibaba.com \
--to=guangguan.wang@linux.alibaba.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=horms@kernel.org \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox