From: Janosch Frank <frankja@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>, imbrenda@linux.ibm.com, thuth@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v1 1/2] s390x: spec_ex-sie: refactor to use snippet API
Date: Fri, 3 Nov 2023 13:09:36 +0100 [thread overview]
Message-ID: <795cc64c-80ff-463c-8456-72aacb15bada@linux.ibm.com> (raw)
In-Reply-To: <20231103064132.11358-2-nrb@linux.ibm.com>
On 11/3/23 07:35, Nico Boehr wrote:
> spec_ex-sie uses a snippet, but allocated the memory on its own without
> obvious reason to do so.
>
> Refactor the test to use snippet_init().
Hmm, is the test pre-snippet?
Anyway:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
next prev parent reply other threads:[~2023-11-03 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 6:35 [kvm-unit-tests PATCH v1 0/2] s390x: Align SIE tests to 2GB Nico Boehr
2023-11-03 6:35 ` [kvm-unit-tests PATCH v1 1/2] s390x: spec_ex-sie: refactor to use snippet API Nico Boehr
2023-11-03 12:09 ` Janosch Frank [this message]
2023-11-03 6:35 ` [kvm-unit-tests PATCH v1 2/2] s390x: sie: ensure guests are aligned to 2GB Nico Boehr
2023-11-03 13:33 ` Claudio Imbrenda
2023-11-03 12:14 ` [kvm-unit-tests PATCH v1 0/2] s390x: Align SIE tests " Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795cc64c-80ff-463c-8456-72aacb15bada@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox