From: Alexandra Winter <wintera@linux.ibm.com>
To: Li RongQing <lirongqing@baidu.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
dust.li@linux.alibaba.com
Subject: Re: [PATCH net-next v4] net/smc: remove unneeded atomic operations in smc_tx_sndbuf_nonempty
Date: Fri, 24 Nov 2023 13:16:34 +0100 [thread overview]
Message-ID: <7aca0393-0369-4d03-bbb7-074c9e5ec1d3@linux.ibm.com> (raw)
In-Reply-To: <20231123014537.9786-1-lirongqing@baidu.com>
On 23.11.23 02:45, Li RongQing wrote:
> The commit dcd2cf5f2fc0 ("net/smc: add autocorking support") adds an
> atomic variable tx_pushing in smc_connection to make sure only one can
> send to let it cork more and save CDC slot. since smc_tx_pending can be
> called in the soft IRQ without checking sock_owned_by_user() at that
> time, which would cause a race condition because bh_lock_sock() did
> not honor sock_lock()
>
> After commit 6b88af839d20 ("net/smc: don't send in the BH context if
> sock_owned_by_user"), the transmission is deferred to when sock_lock()
> is held by the user. Therefore, we no longer need tx_pending to hold
> message.
>
> So remove atomic variable tx_pushing and its operation, and
> smc_tx_sndbuf_nonempty becomes a wrapper of __smc_tx_sndbuf_nonempty,
> so rename __smc_tx_sndbuf_nonempty back to smc_tx_sndbuf_nonempty
>
> Suggested-by: Alexandra Winter <wintera@linux.ibm.com>
> Co-developed-by: Dust Li <dust.li@linux.alibaba.com>
> Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
Looks good to me.
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
However I think this time you did not use scripts/get_maintainer.pl [1]
to determine the correct recipient list for this email.
[1] https://www.kernel.org/doc/html/v6.3/process/submitting-patches.html#submittingpatches
next prev parent reply other threads:[~2023-11-24 12:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 1:45 [PATCH net-next v4] net/smc: remove unneeded atomic operations in smc_tx_sndbuf_nonempty Li RongQing
2023-11-24 12:16 ` Alexandra Winter [this message]
2023-11-24 12:55 ` Wenjia Zhang
2023-11-28 1:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aca0393-0369-4d03-bbb7-074c9e5ec1d3@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=dust.li@linux.alibaba.com \
--cc=linux-s390@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox