From: Stefan Haberland <sth@linux.ibm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jan Hoeppner <hoeppner@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] s390/dasd: Fix a precision vs width bug in dasd_feature_list()
Date: Thu, 27 Jun 2019 16:14:54 +0200 [thread overview]
Message-ID: <7b33439f-6f70-74de-0861-91081e6e048d@linux.ibm.com> (raw)
In-Reply-To: <20190626100658.GB3242@mwanda>
On 26.06.19 12:06, Dan Carpenter wrote:
> The "len" variable is the length of the option up to the next option or
> to the end of the string which ever first. We want to print the invalid
> option so we want precision "%.*s" but the format is width "%*s" so it
> prints up to the end of the string.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Not tested.
Thanks for the patch. I tested it and it works as expected.
Will integrate it through the s390 tree.
prev parent reply other threads:[~2019-06-27 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:06 [PATCH] s390/dasd: Fix a precision vs width bug in dasd_feature_list() Dan Carpenter
2019-06-27 14:14 ` Stefan Haberland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b33439f-6f70-74de-0861-91081e6e048d@linux.ibm.com \
--to=sth@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox