From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: imbrenda@linux.ibm.com, linux-s390@vger.kernel.org, pasic@linux.ibm.com
Subject: Re: [PATCH v4 2/3] KVM: s390: Kick PV cpus at the right time for service irqs
Date: Fri, 25 Sep 2026 12:11:39 +0200 [thread overview]
Message-ID: <7d80b6c3-ff7e-4be7-8bee-899fe08c98a7@linux.ibm.com> (raw)
In-Reply-To: <20260820121546.24694-3-frankja@linux.ibm.com>
Am 20.08.26 um 14:12 schrieb Janosch Frank:
> +void kvm_s390_pv_sclp_kick(struct kvm_vcpu *vcpu)
> +{
> + /*
> + * The cpu that called sclp likely will also take the IRQ, no
> + * need to kick anyone.
> + */
> + if (likely(deliverable_irqs(vcpu) & BIT(IRQ_PEND_EXT_SERVICE)))
> + return;
Get rid of likely please (unless you have verified this).
IIRC, the Linux kernel calls servc with interrupts disabled in most places.
next prev parent reply other threads:[~2026-09-25 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 12:12 [PATCH v4 0/3] KVM: s390: Improve floating IRQ injection behavior Janosch Frank
2026-08-20 12:12 ` [PATCH v4 1/3] " Janosch Frank
2026-08-20 12:31 ` sashiko-bot
2026-09-25 9:26 ` Christian Borntraeger
2026-09-25 13:45 ` Janosch Frank
2026-09-25 13:48 ` Christian Borntraeger
2026-08-20 12:12 ` [PATCH v4 2/3] KVM: s390: Kick PV cpus at the right time for service irqs Janosch Frank
2026-08-20 12:30 ` sashiko-bot
2026-09-25 9:35 ` Christian Borntraeger
2026-09-25 10:11 ` Christian Borntraeger [this message]
2026-08-20 12:12 ` [PATCH v4 3/3] KVM: s390: Add opportunistic floating IRQ injection Janosch Frank
2026-08-20 12:27 ` sashiko-bot
2026-09-25 10:04 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d80b6c3-ff7e-4be7-8bee-899fe08c98a7@linux.ibm.com \
--to=borntraeger@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox