From: Thomas Huth <thuth@redhat.com>
To: Andrew Jones <andrew.jones@linux.dev>,
kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org
Cc: pbonzini@redhat.com, lvivier@redhat.com, frankja@linux.ibm.com,
imbrenda@linux.ibm.com, nrb@linux.ibm.com, atishp@rivosinc.com,
cade.richard@berkeley.edu, jamestiotio@gmail.com
Subject: Re: [kvm-unit-tests PATCH 1/3] riscv: Drop mstrict-align
Date: Wed, 4 Sep 2024 08:12:25 +0200 [thread overview]
Message-ID: <7ef4ee12-ce0b-41e6-904a-ff43ee571be1@redhat.com> (raw)
In-Reply-To: <20240903163046.869262-6-andrew.jones@linux.dev>
On 03/09/2024 18.30, Andrew Jones wrote:
> The spec says unaligned accesses are supported, so this isn't required
> and clang doesn't support it. A platform might have slow unaligned
> accesses, but kvm-unit-tests isn't about speed anyway.
>
> Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
> ---
> riscv/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/riscv/Makefile b/riscv/Makefile
> index 179a373dbacf..2ee7c5bb5ad8 100644
> --- a/riscv/Makefile
> +++ b/riscv/Makefile
> @@ -76,7 +76,7 @@ LDFLAGS += -melf32lriscv
> endif
> CFLAGS += -DCONFIG_RELOC
> CFLAGS += -mcmodel=medany
> -CFLAGS += -mstrict-align
> +#CFLAGS += -mstrict-align
> CFLAGS += -std=gnu99
> CFLAGS += -ffreestanding
> CFLAGS += -O2
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-09-04 6:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 16:30 [kvm-unit-tests PATCH 0/3] Support cross compiling with clang Andrew Jones
2024-09-03 16:30 ` [kvm-unit-tests PATCH 1/3] riscv: Drop mstrict-align Andrew Jones
2024-09-04 6:12 ` Thomas Huth [this message]
2024-09-03 16:30 ` [kvm-unit-tests PATCH 2/3] configure: Support cross compiling with clang Andrew Jones
2024-09-04 6:10 ` Thomas Huth
2024-09-03 16:30 ` [kvm-unit-tests PATCH 3/3] riscv: gitlab-ci: Add clang build tests Andrew Jones
2024-09-04 6:12 ` Thomas Huth
2024-09-04 10:31 ` [kvm-unit-tests PATCH 0/3] Support cross compiling with clang Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef4ee12-ce0b-41e6-904a-ff43ee571be1@redhat.com \
--to=thuth@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=atishp@rivosinc.com \
--cc=cade.richard@berkeley.edu \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jamestiotio@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
--cc=nrb@linux.ibm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox