From: Markus Elfring <Markus.Elfring@web.de>
To: Suman Ghosh <sumang@marvell.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
Alexandra Winter <wintera@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Wenjia Zhang <wenjia@linux.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] net/iucv: Improve unlocking in iucv_enable()
Date: Tue, 2 Jan 2024 08:38:28 +0100 [thread overview]
Message-ID: <8123a895-c7dd-4a75-94bc-6f61639621eb@web.de> (raw)
In-Reply-To: <SJ0PR18MB5216C27127E46490951A1E5DDB61A@SJ0PR18MB5216.namprd18.prod.outlook.com>
> @@ -555,13 +555,16 @@ static int iucv_enable(void)
>> if (cpumask_empty(&iucv_buffer_cpumask))
>> /* No cpu could declare an iucv buffer. */
>> goto out;
>> +
>> + rc = 0;
>> +unlock:
>> cpus_read_unlock();
>> - return 0;
>> + return rc;
>> +
>> out:
>> kfree(iucv_path_table);
>> iucv_path_table = NULL;
>> - cpus_read_unlock();
>> - return rc;
>> + goto unlock;
> [Suman] This looks confusing. What is the issue with retaining the original change?
I propose to reduce the number of cpus_read_unlock() calls
(in the source code).
Regards,
Markus
next prev parent reply other threads:[~2024-01-02 7:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-01 20:56 [PATCH 0/2] net/iucv: Adjustments for iucv_enable() Markus Elfring
2024-01-01 20:58 ` [PATCH 1/2] net/iucv: Improve unlocking in iucv_enable() Markus Elfring
2024-01-02 6:44 ` [EXT] " Suman Ghosh
2024-01-02 7:38 ` Markus Elfring [this message]
2024-01-02 8:27 ` [EXT] " Suman Ghosh
2024-01-02 9:53 ` Alexandra Winter
2024-01-02 10:31 ` Markus Elfring
2024-01-01 21:00 ` [PATCH 2/2] net/iucv: Improve error handling " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8123a895-c7dd-4a75-94bc-6f61639621eb@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sumang@marvell.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox