public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: linux-s390@vger.kernel.org,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] s390x/mm: avoid taking the table lock in gmap_pmd_op_walk()
Date: Tue, 7 Aug 2018 10:35:56 +0200	[thread overview]
Message-ID: <85e72251-fa72-9a3f-e2b0-6bc7d9482908@redhat.com> (raw)
In-Reply-To: <d3e543bc-d0ff-c8ef-f097-eeba2bde6971@linux.ibm.com>

On 07.08.2018 09:26, Janosch Frank wrote:
> On 06.08.2018 17:54, David Hildenbrand wrote:
>> Right now we temporarily take the page table lock in gmap_pmd_op_walk()
>> even though we know we won't need it (if we can never have 1mb pages
>> mapped into the gmap).
>>
>> So let's special case this, so
>> gmap_protect_range()/gmap_sync_dirty_log_pmd() will not take the lock in
>> case huge pages are not allowed.
> 
> So, let's make this a special case
> 
>>
>> gmap_protect_range() is called quite frequently for managing shadow
>> page tables in vSIE environments.
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
> 
> If you make the patch title more specific:
> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>


"s390/mm: optimize locking without huge pages in gmap_pmd_op_walk()"

Thanks!

-- 

Thanks,

David / dhildenb

      reply	other threads:[~2018-08-07  8:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-06 15:54 [PATCH] s390x/mm: avoid taking the table lock in gmap_pmd_op_walk() David Hildenbrand
2018-08-07  7:26 ` Janosch Frank
2018-08-07  8:35   ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85e72251-fa72-9a3f-e2b0-6bc7d9482908@redhat.com \
    --to=david@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox