From: Li Qiang <liqiang64@huawei.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>, <wenjia@linux.ibm.com>,
<jaka@linux.ibm.com>, <tonylu@linux.alibaba.com>,
<guwen@linux.alibaba.com>
Cc: <linux-s390@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <luanjianhai@huawei.com>,
<zhangxuzhou4@huawei.com>, <dengguangxing@huawei.com>,
<gaochao24@huawei.com>
Subject: Re: [PATCH] net/smc: Optimize the search method of reused buf_desc
Date: Mon, 4 Nov 2024 15:34:45 +0800 [thread overview]
Message-ID: <866b75ce-1692-5878-5b98-ec2a12e665bc@huawei.com> (raw)
In-Reply-To: <58333f24-ae0a-4860-a6a8-37fef09165a0@linux.alibaba.com>
在 2024/11/4 9:41, D. Wythe 写道:
>
>
> On 10/29/24 2:54 PM, liqiang wrote:
>> We create a lock-less link list for the currently
>> idle reusable smc_buf_desc.
>>
>> When the 'used' filed mark to 0, it is added to
>> the lock-less linked list.
>>
>> When a new connection is established, a suitable
>> element is obtained directly, which eliminates the
>> need for traversal and search, and does not require
>> locking resource.
>>
>> A lock-free linked list is a linked list that uses
>> atomic operations to optimize the producer-consumer model.
>
>
>
> No objection, but could you provide us with some data before and after the optimization ?
> .
I have resent this patch a few days ago with '[PATCH net-next]' prefix.
It contains more detailed function time-consuming and nginx test data.
You can find some test data in that email. :)
Let me summarize it here:
1. The function 'smc_buf_get_slot' takes less time when a new SMC link is established,
5us->100ns (when there are 200 active links), 30us->100ns (when there are 1000 active links).
2. Using wrk and nginx to test multi-threaded short connection performance
has significantly improved.
Environment: QEMU emulator version 1.5.3 @ Intel(R) Xeon(R) CPU E5-2680 v4 @ 2.40GHz
Test with SMC loopback-ism.
--
Best regards,
Li Qiang
prev parent reply other threads:[~2024-11-04 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 6:54 [PATCH] net/smc: Optimize the search method of reused buf_desc liqiang
2024-11-01 2:06 ` Jakub Kicinski
2024-11-01 3:11 ` Li Qiang
2024-11-01 6:50 ` Dust Li
2024-11-01 8:27 ` Li Qiang
2024-11-04 1:41 ` D. Wythe
2024-11-04 7:34 ` Li Qiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=866b75ce-1692-5878-5b98-ec2a12e665bc@huawei.com \
--to=liqiang64@huawei.com \
--cc=alibuda@linux.alibaba.com \
--cc=dengguangxing@huawei.com \
--cc=gaochao24@huawei.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=luanjianhai@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
--cc=zhangxuzhou4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox