Re: [PATCH 1/1] s390/kexec: handle R_390_PLT32DBL reloc entries in arch_kexec_do_relocs()

[Alexander Egorenkov <egorenar@linux.ibm.com>]

Hi Philipp,

Philipp Rudo <prudo@redhat.com> writes:

> Hi Alexander,
>
> thanks for taking care of this so fast!
>
> My personal approach was slightly different (see below). The idea
> behind this was that arch_kexec_do_relocs is also used by others which
> might have a PLT. For them your approach would mean an ABI breakage. On
> the other hand in case the other users have the same problem they would
> need to handle it for themselves. Not sure what's the better approach.
>

I'm also fine with your proposal for the fix.

If i'm not mistaken, arch_kexec_do_relocs() is used in decompressor and
for purgatory at the moment, and both should have all relocs resolved.
Do we have more users of arch_kexec_do_relocs() ? That was the reason i
added the fix to arch_kexec_do_relocs().

Now i'm actually wondering why we don't have any issues with
decompressor, probably because we do the final link where all
PLT-relative addresses are fixed. Because i see plenty of R_390_PLT32DBL
in startup.o e.g.

Thanks for feedback
Regards
Alex