public inbox for linux-s390@vger.kernel.org
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>, borntraeger@de.ibm.com
Cc: david@redhat.com, linux-kernel@vger.kernel.org,
	cohuck@redhat.com, linux-s390@vger.kernel.org,
	kvm@vger.kernel.org, frankja@linux.ibm.com,
	akrowiak@linux.ibm.com
Subject: Re: [PATCH v1 0/2] KVM: s390: Tracing APCB changes
Date: Fri, 5 Oct 2018 12:55:51 +0200	[thread overview]
Message-ID: <879f5959-b0c9-9bed-7178-acf217aefd53@linux.ibm.com> (raw)
In-Reply-To: <1538728270-10340-1-git-send-email-pmorel@linux.ibm.com>



On 10/05/2018 10:31 AM, Pierre Morel wrote:
> In the first patch we define kvm_arch_crypto_set_masks,
> a new function to centralize the setup the APCB masks
> inside the CRYCB SIE satelite and add KVM_EVENT() to
> kvm_arch_crypto_set_masks and kvm_arch_crypto_clear_masks.
> 
> In the second patch we replace the vfio_ap_mdev_copy_masks()
> by the new kvm_arch_crypto_set_masks() function.
> 

FWIW I also like this version better. And accommodating for on-the
fly changes seems to be showing in the right direction anyway.

I did not look into the details but it looks good to me.

Halil

  parent reply	other threads:[~2018-10-05 10:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05  7:33 [PATCH] s390: vfio-ap: trace the update of APCB masks Pierre Morel
2018-10-05  7:50 ` Cornelia Huck
2018-10-05  7:54   ` David Hildenbrand
2018-10-05  8:06     ` Christian Borntraeger
2018-10-05  8:31       ` [PATCH v1 0/2] KVM: s390: Tracing APCB changes Pierre Morel
2018-10-05  8:31         ` [PATCH v1 1/2] " Pierre Morel
2018-10-05  8:49           ` Cornelia Huck
2018-10-05  8:57             ` Pierre Morel
2018-10-05  9:30               ` Cornelia Huck
2018-10-05  8:31         ` [PATCH v1 2/2] s390: vfio-ap: setup APCB mask using KVM dedicated function Pierre Morel
2018-10-05  9:31           ` Cornelia Huck
2018-10-05  9:42           ` David Hildenbrand
2018-10-05  8:44         ` [PATCH v1 0/2] KVM: s390: Tracing APCB changes Cornelia Huck
2018-10-05  8:56           ` David Hildenbrand
2018-10-05 10:55         ` Halil Pasic [this message]
2018-10-05 11:16         ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=879f5959-b0c9-9bed-7178-acf217aefd53@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox