From: Thorsten Blum <thorsten.blum@linux.dev>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/nmi: Simplify return statement in nmi_registers_valid()
Date: Tue, 9 Sep 2025 10:08:10 +0200 [thread overview]
Message-ID: <87A2F1E0-17E4-4C28-823A-3D6C3379DF41@linux.dev> (raw)
In-Reply-To: <20250909062501.8968Abb-hca@linux.ibm.com>
On 9. Sep 2025, at 08:25, Heiko Carstens wrote:
> On Mon, Sep 08, 2025 at 06:52:11PM +0200, Alexander Gordeev wrote:
>>
>> This change does not make the whole function readability better.
>
> It actually would decrease readability since every if-statement tells
> you one condition when registers are not valid. Negating the last one
> makes this harder to understand.
Ah my bad, that makes sense. I didn't take the whole function into
account.
Thanks,
Thorsten
prev parent reply other threads:[~2025-09-09 8:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 15:32 [PATCH] s390/nmi: Simplify return statement in nmi_registers_valid() Thorsten Blum
2025-09-08 16:52 ` Alexander Gordeev
2025-09-09 6:25 ` Heiko Carstens
2025-09-09 8:08 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87A2F1E0-17E4-4C28-823A-3D6C3379DF41@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox