From: Marc Zyngier <maz@kernel.org>
To: Jing Zhang <jingzhangos@google.com>
Cc: KVM <kvm@vger.kernel.org>, KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Linuxkselftest <linux-kselftest@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Mackerras <paulus@ozlabs.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
David Rientjes <rientjes@google.com>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Subject: Re: [PATCH v4 1/4] KVM: stats: Separate common stats from architecture specific ones
Date: Fri, 30 Apr 2021 13:07:19 +0100 [thread overview]
Message-ID: <87bl9wnfgo.wl-maz@kernel.org> (raw)
In-Reply-To: <20210429203740.1935629-2-jingzhangos@google.com>
On Thu, 29 Apr 2021 21:37:37 +0100,
Jing Zhang <jingzhangos@google.com> wrote:
> +struct kvm_vm_stat_common {
> + ulong remote_tlb_flush;
> +};
> +
> +struct kvm_vcpu_stat_common {
> + u64 halt_successful_poll;
> + u64 halt_attempted_poll;
> + u64 halt_poll_invalid;
> + u64 halt_wakeup;
> + u64 halt_poll_success_ns;
> + u64 halt_poll_fail_ns;
> +};
Why can't we make everything a u64? Is there anything that really
needs to be a ulong? On most architectures, they are the same anyway,
so we might as well bite the bullet.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2021-04-30 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 20:37 [PATCH v4 0/4] KVM statistics data fd-based binary interface Jing Zhang
2021-04-29 20:37 ` [PATCH v4 1/4] KVM: stats: Separate common stats from architecture specific ones Jing Zhang
2021-04-30 12:07 ` Marc Zyngier [this message]
2021-04-30 15:34 ` Jing Zhang
2021-04-29 20:37 ` [PATCH v4 2/4] KVM: stats: Add fd-based API to read binary stats data Jing Zhang
2021-04-30 1:26 ` kernel test robot
2021-04-30 2:26 ` Jing Zhang
2021-04-29 20:37 ` [PATCH v4 3/4] KVM: stats: Add documentation for statistics data binary interface Jing Zhang
2021-04-29 20:37 ` [PATCH v4 4/4] KVM: selftests: Add selftest for KVM " Jing Zhang
2021-05-10 18:57 ` [PATCH v4 0/4] KVM statistics data fd-based " Jing Zhang
2021-05-11 8:38 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl9wnfgo.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=chenhuacai@kernel.org \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=eesposit@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=jmattson@google.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=oupton@google.com \
--cc=paulus@ozlabs.org \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tsbogend@alpha.franken.de \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox