Linux s390 Architecture development
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: "Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
	"Nico Böhr" <nrb@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: Re: [PATCH] s390x: stsi: regression test for the STSI 3.2.2 count clamp
Date: Tue, 30 Jun 2026 15:21:49 +0200	[thread overview]
Message-ID: <87ik70kvte.fsf@redhat.com> (raw)
In-Reply-To: <20260629091921.710920-1-borntraeger@linux.ibm.com>

On Mon, Jun 29 2026, Christian Borntraeger <borntraeger@linux.ibm.com> wrote:

> See https://lore.kernel.org/qemu-devel/20260622092035.400959-1-borntraeger@linux.ibm.com/
> for the QEMU fix.

Could now also refer to QEMU commit a57e4612b61d ("s390x/kvm: clamp stsi
3.2.2 size") directly.

> Add a regression test that races STSI 3.2.2 on one CPU against a second CPU
> that continuously forces an out-of-range count value.
> The out of bound access usually crashes/asserts QEMU with any sane
> distribution build of QEMU, so its more or less guest root can kill itself.
> We should test and fix nevertheless.
> Testcase piggybacks on the existing stsi test, so some cases will be
> tested twice. (with smp 1 and smp 2)
>
> Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> ---
> If wanted we could split this into a separate file or always run the
> test with smp=2 to avoid the duplication

I think it's reasonable to keep this with the other STSI tests.

>
>  s390x/stsi.c        | 76 ++++++++++++++++++++++++++++++++++++++++++++-
>  s390x/unittests.cfg |  9 ++++++
>  2 files changed, 84 insertions(+), 1 deletion(-)
>

FWIW,

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


      reply	other threads:[~2026-06-30 13:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-29  9:19 [PATCH] s390x: stsi: regression test for the STSI 3.2.2 count clamp Christian Borntraeger
2026-06-30 13:21 ` Cornelia Huck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ik70kvte.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox