From: Wenjia Zhang <wenjia@linux.ibm.com>
To: Wen Gu <guwen@linux.alibaba.com>,
wintera@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com,
jaka@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
raspl@linux.ibm.com, schnelle@linux.ibm.com,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support
Date: Wed, 29 Nov 2023 13:50:54 +0100 [thread overview]
Message-ID: <937d6964-b3c3-4ff5-b864-881d7de58bd1@linux.ibm.com> (raw)
In-Reply-To: <1700836935-23819-1-git-send-email-guwen@linux.alibaba.com>
On 24.11.23 15:42, Wen Gu wrote:
> The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
> SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
> OS or hypervisor software, comparable to IBM ISM which is based on platform
> firmware or hardware.
>
> With the introduction of virtual ISM, SMCv2.1 makes some updates:
>
> - Introduce feature bitmask to indicate supplemental features.
> - Reserve a range of CHIDs for virtual ISM.
> - Support extended GIDs (128 bits) in CLC handshake.
>
> So this patch set aims to implement these updates in Linux kernel. And it
> acts as the first part of SMC-D virtual ISM extension & loopback-ism [1].
>
> [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@linux.alibaba.com/
>
> v2->v1:
> - Fix sparse complaint;
> - Rebase to the latest net-next;
>
It looks good to me. The testing looks good as well.
If these comments are worked out, I'd like to give my Reviewed-by for
the next version.
BTW, for the next version, you need to rebase your kernel.
prev parent reply other threads:[~2023-11-29 12:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 14:42 [PATCH net-next v2 0/7] net/smc: implement SMCv2.1 virtual ISM device support Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 1/7] net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity Wen Gu
2023-11-29 12:50 ` Wenjia Zhang
2023-11-30 11:02 ` Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 2/7] net/smc: support SMCv2.x supplemental features negotiation Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 3/7] net/smc: introduce virtual ISM device support feature Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 4/7] net/smc: define a reserved CHID range for virtual ISM devices Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 5/7] net/smc: compatible with 128-bits extend GID of virtual ISM device Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 6/7] net/smc: disable SEID on non-s390 archs where virtual ISM may be used Wen Gu
2023-11-24 14:42 ` [PATCH net-next v2 7/7] net/smc: manage system EID in SMC stack instead of ISM driver Wen Gu
2023-11-27 14:04 ` Alexandra Winter
2023-11-28 3:13 ` Wen Gu
2023-11-29 12:50 ` Wenjia Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=937d6964-b3c3-4ff5-b864-881d7de58bd1@linux.ibm.com \
--to=wenjia@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox